Delay conversion of Truffle function body nodes until the function is invoked #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kustosz
approved these changes
May 4, 2022
| @@ -30,6 +30,10 @@ public static BlockNode build(ExpressionNode[] expressions, ExpressionNode retur | |||
| return new BlockNode(expressions, returnExpr); | |||
| } | |||
|
|
|||
| public static BlockNode buildSilent(ExpressionNode[] expressions, ExpressionNode returnExpr) { | |||
There was a problem hiding this comment.
This one is used from AtomConstructor.buildConstructorFunction. Those functions are usually quite small - not sure it makes sense to make them lazy.
engine/runtime/src/main/scala/org/enso/compiler/codegen/IrToTruffle.scala
Outdated
Show resolved
Hide resolved
JaroslavTulach
requested review from
MichaelMauderer,
wdanilo,
PabloBuchu and
jdunkerley
as code owners
hubertp
approved these changes
May 5, 2022
engine/runtime/src/main/scala/org/enso/compiler/codegen/IrToTruffle.scala
Show resolved
Hide resolved
engine/runtime/src/main/scala/org/enso/compiler/codegen/IrToTruffle.scala
Show resolved
Hide resolved
4 tasks
mwu-tow
pushed a commit
that referenced
this pull request
May 9, 2022
Patch provided by Jaroslav, appears to fix local issues with inifite loop introduced in #3429. ### Important Notes This renders #3439 obsolete. Related to https://www.pivotaltracker.com/n/projects/2539304/stories/182024911
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Most of the functions in the standard library aren't gonna be invoked during particular program execution. It makes no sense to build their Truffle AST for the functions that are not executing. Let's delay the construction of the tree until a function is first executed.
Checklist
Please include the following checklist in your PR: