Upgrade to GraalVM 22.3.0

[JaroslavTulach]

Pull Request Description

Upgrading to GraalVM 22.3.0.

Important Notes

• Removed all deprecated FrameSlot, and replaced them with frame indexes - integers.
  • Add more information to AliasAnalysis so that it also gathers these indexes.
• Add quick build mode option to native-image as default for non-release builds
• graaljs and native-image should now be downloaded via gu automatically, as dependencies.
• Remove engine-runner-native project - native image is now build straight from engine-runner.
  • We used to have engine-runner-native without sqldf in classpath as a workaround for an internal native image bug.
• Fixed chrome inspector integration, such that it shows values of local variables both for current stack frame and caller stack frames.
  • There are still many issues with the debugging in general, for example, when there is a polyglot value among local variables, a NullPointerException is thrown and no values are displayed.
• Removed some deprecated native-image options
• Remove some deprecated Truffle API method calls.

Checklist

Please include the following checklist in your PR:

• The documentation has been updated if necessary.
• All code conforms to the
  Scala,
  Java,
  and
  Rust
  style guides.
• All code has been tested:
  • Unit tests have been written where possible.
  • If GUI codebase was changed: Enso GUI was tested when built using BOTH
    ./run ide build and ./run ide watch.

[kustosz]

I'm happy with this as long as it works and does not cause performance regressions :)

[JaroslavTulach]

CI run shows that the DebuggingEnsoTest is failing. Local variables aren't visible as the default visualization doesn't work for int based variable indexes. That's going to take a time, but it is an opportunity to display variable values properly.

[JaroslavTulach]

Formatting CI check seems to be using GraalVM 21.3 instead of 22.1. Ccing @mwu-tow ...

[jtulach]

CI run shows that the DebuggingEnsoTest is failing. Local variables aren't visible as the default visualization doesn't work for int based variable indexes. That's going to take a time, but it is an opportunity to display variable values properly.

Right. The reason why this particular test does not work is that the default implementation of NodeLibrary ( DefaultfNodeExports$DefaultScope.readMember ) reads only auxiliary slots from the frame, but ignores all the indexed slots. For, now deprecated, FrameSlot it was OK, because the default implementation just traversed all the FrameSlots. We have to correctly implement this behavior by exporting scope messages from NodeLibrary in BaseNode or ExpressionNode. The getScope message would return a TruffleObject representing a scope that would export all member and scope messages from InteropLibrary, where there are parent scopes, among other things.

I suggest we ignore, or provide a quick fix, for this test for now, and create a follow-up issue to implement variable displaying in the Truffle debugger properly.

[mwu-tow]

@JaroslavTulach

Formatting CI check seems to be using GraalVM 21.3 instead of 22.1. Ccing @mwu-tow ...

The workflow has hardcoded GraalVM version, it needs to be bumped as well.

You don't need to do this for my build-script-based workflows, as the build script parses build.sbt to figure out proper GraalVM version.

[JaroslavTulach]

Checking the failures is see two:

• correctly pattern match on array like values
• ArrayList doesn't equal ArrayList

Great job! Looks like you'll be able to merge soon.

[hubertp]

Some suggestions but LGTM otherwise. Also, slightly changed sbt to avoid multiple installations of native-image

[4e6]

I seems that each GraalVM update is becoming increasingly harder. Happy that it is finally done ❤️

[hubertp]

nits

[hubertp]

there is a isWrapper method that does this instance check and it seems that in unwrapDelegate we don't mind casting the node so maybe stick to one style?

[Akirathan]

Probably. But then I don't get this fancy Java pattern matching instanceof. Nevertheless, I would not bother with this code that much, as it will probably be rewritten within a few weeks, once I get to a more proper support for debugging.

[mwu-tow]

This logic already is present in the RRust build script, if you use it to enter sbt shell then you'll have native-image installed.

[Akirathan]

I have just recently noticed that. Nevertheless we still need installGraalJs, as it is not shipped by default in the latest GraalVM release. Moreover, this task does not install anything, if native-image is already installed. The same is true for installGraalJs. Besides, I don't know how other engine devs, but I don't usually use the rust build script, I just use sbt, which makes these two tasks very convenient.