Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid whole source reparsing when the IDE performs a simple edit #3508

Merged
merged 67 commits into from
Jun 16, 2022
Merged

Avoid whole source reparsing when the IDE performs a simple edit #3508

merged 67 commits into from
Jun 16, 2022

Commits on Jun 1, 2022

  1. IncrementalUpdatesTest is a copy of RuntimeServerTest written in Java

    @JaroslavTulach
    JaroslavTulach committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    cecd735 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Recognize simple TextEdit change

    @JaroslavTulach
    JaroslavTulach committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    8532a9a View commit details
    Browse the repository at this point in the history

  2. Eliminating useless Scala <-> Java collection conversions

    @JaroslavTulach
    JaroslavTulach committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    9aeeb2e View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Use node counting instrument to fail when reparsing happens

    @JaroslavTulach
    JaroslavTulach committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    fd7f238 View commit details
    Browse the repository at this point in the history

  2. No need to create a dummy node. Return null

    @JaroslavTulach
    JaroslavTulach committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    ccce1fd View commit details
    Browse the repository at this point in the history

  3. Identify simple edit and apply it to right Truffle node

    @JaroslavTulach
    JaroslavTulach committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    8bd50ab View commit details
    Browse the repository at this point in the history

  4. Hack to treat IDE's simple+comment edit as a simple edit

    @JaroslavTulach
    JaroslavTulach committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    fab4189 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2022

  1. Applying javafmt

    @JaroslavTulach
    JaroslavTulach committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    467fb19 View commit details
    Browse the repository at this point in the history

  2. Associating TruffleFile, Rope, Source into an immutable record and up… 

    …dating them all at once
    @JaroslavTulach
    JaroslavTulach committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    6303000 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2022

  1. Update SourceSections when performing simple edit

    @JaroslavTulach
    JaroslavTulach committed Jun 5, 2022
    Configuration menu
    Copy the full SHA
    1a87a6d View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Survive when changed value isn't a number

    @JaroslavTulach
    JaroslavTulach committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    1164679 View commit details
    Browse the repository at this point in the history

  2. Formatted by scalafmt

    @JaroslavTulach
    JaroslavTulach committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    7603648 View commit details
    Browse the repository at this point in the history

  3. Introducing patchable tag to mark nodes that know how to patch themse… 

    …lves
    @JaroslavTulach
    JaroslavTulach committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    31648ad View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Avoid iterating node subtrees that are clearly off

    @JaroslavTulach
    JaroslavTulach committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    a66862b View commit details
    Browse the repository at this point in the history

  2. Using mapExpressions to update the IR after simple edit

    @JaroslavTulach
    JaroslavTulach committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    28a162a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/develop' into wip/jtulach/Increm… 

    …entalUpdates-182323784
    @JaroslavTulach
    JaroslavTulach committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    86ef968 View commit details
    Browse the repository at this point in the history

  4. receiveNIgnoreStdLib method now requires two arguments

    @JaroslavTulach
    JaroslavTulach committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    40eb24b View commit details
    Browse the repository at this point in the history

  5. Module maintains its latest Source as well as 'deltas' against latest… 

    … AST offsets
    @JaroslavTulach
    JaroslavTulach committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    d7deb6c View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Note in changelog and using a method reference

    @JaroslavTulach
    JaroslavTulach committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    03b58e4 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into wip/jtulach/Increm… 

    …entalUpdates-182323784
    @JaroslavTulach
    JaroslavTulach committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    69a2f98 View commit details
    Browse the repository at this point in the history

  3. Applying proper formatting with javafmtAll

    @JaroslavTulach
    JaroslavTulach committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    45e7bb4 View commit details
    Browse the repository at this point in the history

  4. Generalizing the test to work also on text literals

    @JaroslavTulach
    JaroslavTulach committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    a785033 View commit details
    Browse the repository at this point in the history

  5. Handle simple edits of text literals

    @JaroslavTulach
    JaroslavTulach committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    6797f59 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Applying scalafmt formatting

    @JaroslavTulach
    JaroslavTulach committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    348c18d View commit details
    Browse the repository at this point in the history

  2. Avoid modifications to ModuleScope

    @JaroslavTulach
    JaroslavTulach committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    dea5e92 View commit details
    Browse the repository at this point in the history

  3. Representing interactive state by presence of patchedValues

    @JaroslavTulach
    JaroslavTulach committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    1e4e8a4 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/develop' into wip/jtulach/Increm… 

    …entalUpdates-182323784
    @JaroslavTulach
    JaroslavTulach committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    b97bd2d View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2022

  1. Call Module.createSection to adjust to deltas provided by position ma… 

    …nager
    @JaroslavTulach
    JaroslavTulach committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    48a6c32 View commit details
    Browse the repository at this point in the history

  2. Associate UnwindException with a value and use it in the IdExecutionI… 

    …nstrument
    @JaroslavTulach
    JaroslavTulach committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    f37250c View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. Support inline sources different from those associated with a Module

    @JaroslavTulach
    JaroslavTulach committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    eb865ea View commit details
    Browse the repository at this point in the history

  2. Root node without a source produces no source sections

    @JaroslavTulach
    JaroslavTulach committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    b85e455 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. Merging with develop branch

    @JaroslavTulach
    JaroslavTulach committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    dbe6548 View commit details
    Browse the repository at this point in the history

  2. Enabling use of Frgaal and Truffle in runtime-with-instruments tests

    @JaroslavTulach
    JaroslavTulach committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    0bdfde9 View commit details
    Browse the repository at this point in the history

  3. Moving IncrementalUpdatesTest to runtime-with-instruments project

    @JaroslavTulach
    JaroslavTulach committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    71ff2b6 View commit details
    Browse the repository at this point in the history

  4. Working with WeakHashMap shall be done behind a boundary

    @JaroslavTulach
    JaroslavTulach committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    919ab9d View commit details
    Browse the repository at this point in the history

  5. Adding withDebug commands to runtime-with-instruments

    @JaroslavTulach
    JaroslavTulach committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    d78f850 View commit details
    Browse the repository at this point in the history

  6. Use pattern matching to find SimpleUpdate case class

    @JaroslavTulach
    JaroslavTulach committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    a84ae04 View commit details
    Browse the repository at this point in the history

  7. Proper formatting

    @JaroslavTulach
    JaroslavTulach committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    2cc359e View commit details
    Browse the repository at this point in the history

  8. Update the Truffle AST from a provided IR.Expression

    @JaroslavTulach
    JaroslavTulach committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    d754e16 View commit details
    Browse the repository at this point in the history

  9. Share conversion of number literal to runtime value between parsing a… 

    …nd patching
    @JaroslavTulach
    JaroslavTulach committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    c80567a View commit details
    Browse the repository at this point in the history

  10. Subsequent updates scan the previously modified nodes for a match

    @JaroslavTulach
    JaroslavTulach committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    c156570 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Uses SlowToInstrumentTag. RuntimeInstrumentTest 8:3 with should not i… 

    …nstrument the body of a lambda failing as first
    @JaroslavTulach
    JaroslavTulach committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    a680c25 View commit details
    Browse the repository at this point in the history

  2. Trading one again failing test for three passing. Score is 10:1

    @JaroslavTulach
    JaroslavTulach committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    56131f3 View commit details
    Browse the repository at this point in the history

  3. All 11 tests of RuntimeInstrumentTest is passing

    @JaroslavTulach
    JaroslavTulach committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    4c039ff View commit details
    Browse the repository at this point in the history

  4. Removing LocationFilter

    @JaroslavTulach
    JaroslavTulach committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    41c81e0 View commit details
    Browse the repository at this point in the history

  5. Always expect ClosureRootNode from the entryCallTarget

    @JaroslavTulach
    JaroslavTulach committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    3a10046 View commit details
    Browse the repository at this point in the history

  6. Renamed to AvoidIdInstrumentationTag

    @JaroslavTulach
    JaroslavTulach committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    cc94d61 View commit details
    Browse the repository at this point in the history

  7. No changes in test needed

    @JaroslavTulach
    JaroslavTulach committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    4891467 View commit details
    Browse the repository at this point in the history

  8. Documenting the purpose of PatchedModuleValues

    @JaroslavTulach
    JaroslavTulach committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    03ddb48 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'jtulach/RewriteLocationFilter' into wip/jtulach/Increme… 

    …ntalUpdates-182323784
    @JaroslavTulach
    JaroslavTulach committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    162ed20 View commit details
    Browse the repository at this point in the history

  10. Documentation for ModuleSources

    @JaroslavTulach
    JaroslavTulach committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    2d9e4ef View commit details
    Browse the repository at this point in the history

  11. Clearing debris and unused imports

    @JaroslavTulach
    JaroslavTulach committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    8959ba2 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. Compute simpleUpdate with the help of map and filter

    @JaroslavTulach
    JaroslavTulach committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    ba152bc View commit details
    Browse the repository at this point in the history

  2. Javadoc clarification 

    Co-authored-by: Dmitry Bushev <bushevdv@gmail.com>
    @JaroslavTulach @4e6
    JaroslavTulach and 4e6 committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    08dbd6f View commit details
    Browse the repository at this point in the history

  3. Javadoc clarification 

    Co-authored-by: Dmitry Bushev <bushevdv@gmail.com>
    @JaroslavTulach @4e6
    JaroslavTulach and 4e6 committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    c8f0228 View commit details
    Browse the repository at this point in the history

  4. Addressing another round of comments

    @JaroslavTulach
    JaroslavTulach committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    6c81820 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into wip/jtulach/IncrementalUpdates-182323784

    @mergify
    mergify[bot] committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    9240bda View commit details
    Browse the repository at this point in the history

  6. Connecting documentation of setLiteralSource with PatchedModuleValues

    @JaroslavTulach
    JaroslavTulach committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    52630ed View commit details
    Browse the repository at this point in the history

  7. Explaining meaning of IndexRange.between(firstFunctionLine, afterFunc… 

    …tionLine))
    @JaroslavTulach
    JaroslavTulach committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    fd67025 View commit details
    Browse the repository at this point in the history

  8. More information in Javadoc

    @JaroslavTulach
    JaroslavTulach committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    5d280d5 View commit details
    Browse the repository at this point in the history

  9. newIR.map 

    Co-authored-by: Hubert Plociniczak <hubert.plociniczak@gmail.com>
    @JaroslavTulach @hubertp
    JaroslavTulach and hubertp committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    0a573ed View commit details
    Browse the repository at this point in the history

  10. newIR.map 2 

    Co-authored-by: Hubert Plociniczak <hubert.plociniczak@gmail.com>
    @JaroslavTulach @hubertp
    JaroslavTulach and hubertp committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    ec417c8 View commit details
    Browse the repository at this point in the history

  11. Underscore 

    Co-authored-by: Hubert Plociniczak <hubert.plociniczak@gmail.com>
    @JaroslavTulach @hubertp
    JaroslavTulach and hubertp committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    f088163 View commit details
    Browse the repository at this point in the history

  12. _._2.size 

    Co-authored-by: Hubert Plociniczak <hubert.plociniczak@gmail.com>
    @JaroslavTulach @hubertp
    JaroslavTulach and hubertp committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    f54d387 View commit details
    Browse the repository at this point in the history

  13. Ensure only IR.Literal is returned

    @JaroslavTulach
    JaroslavTulach committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    7144dbc View commit details
    Browse the repository at this point in the history

  14. Throw CompilerError rather than returning a string with error message

    @JaroslavTulach
    JaroslavTulach committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    a5db906 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'develop' into wip/jtulach/IncrementalUpdates-182323784

    @JaroslavTulach
    JaroslavTulach committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    68a9edf View commit details
    Browse the repository at this point in the history