Avoid whole source reparsing when the IDE performs a simple edit

engine/runtime/src/main/java/org/enso/interpreter/node/expression/literal/IntegerLiteralNode.java

@@ -1,13 +1,18 @@
 package org.enso.interpreter.node.expression.literal;
 
+import com.oracle.truffle.api.Assumption;
+import com.oracle.truffle.api.CompilerDirectives;
+import com.oracle.truffle.api.Truffle;
 import com.oracle.truffle.api.frame.VirtualFrame;
 import com.oracle.truffle.api.nodes.NodeInfo;
 import org.enso.interpreter.node.ExpressionNode;
 
 /** A representation of integer literals in Enso. */
 @NodeInfo(shortName = "IntegerLiteral")
 public final class IntegerLiteralNode extends ExpressionNode {
-  private final long value;
+  private static final Assumption CONSTANTS_ARE_CONSTANTS =
+      Truffle.getRuntime().createAssumption("Constants were never updated");
+  @CompilerDirectives.CompilationFinal private long value;
 
   private IntegerLiteralNode(long value) {
     this.value = value;
@@ -31,6 +36,19 @@ public static IntegerLiteralNode build(long value) {
    */
   @Override
   public Object executeGeneric(VirtualFrame frame) {
+    if (CONSTANTS_ARE_CONSTANTS.isValid()) {
+      return this.value;
+    }
+    return readValue();
+  }
+
+  @CompilerDirectives.TruffleBoundary
+  private Object readValue() {
     return this.value;
   }
+
+  public void updateConstant(String text) {
+    this.value = Long.valueOf(text);
+    CONSTANTS_ARE_CONSTANTS.invalidate();
+  }
 }

engine/runtime/src/main/java/org/enso/interpreter/runtime/Module.java

@@ -17,6 +17,7 @@
 import java.util.logging.Level;
 import org.enso.compiler.ModuleCache;
 import org.enso.compiler.core.IR;
+import org.enso.compiler.core.IR$Literal$Number;
 import org.enso.compiler.phase.StubIrBuilder;
 import org.enso.interpreter.node.callable.dispatch.CallOptimiserNode;
 import org.enso.interpreter.node.callable.dispatch.LoopingCallOptimiserNode;
@@ -34,6 +35,7 @@
 import org.enso.polyglot.LanguageInfo;
 import org.enso.polyglot.MethodNames;
 import org.enso.text.buffer.Rope;
+import org.enso.text.editing.model;
 
 /** Represents a source module with a known location. */
 @ExportLibrary(InteropLibrary.class)
@@ -77,9 +79,7 @@ public boolean isBefore(CompilationStage stage) {
   }
 
   private ModuleScope scope;
-  private TruffleFile sourceFile;
-  private Rope literalSource;
-  private Source cachedSource;
+  private Sources sources;
   private final Package<TruffleFile> pkg;
   private CompilationStage compilationStage = CompilationStage.INITIAL;
   private boolean isIndexed = false;
@@ -99,7 +99,7 @@ public boolean isBefore(CompilationStage stage) {
    * @param sourceFile the module's source file.
    */
   public Module(QualifiedName name, Package<TruffleFile> pkg, TruffleFile sourceFile) {
-    this.sourceFile = sourceFile;
+    this.sources = Sources.NONE.newWith(sourceFile);
     this.pkg = pkg;
     this.name = name;
     this.cache = new ModuleCache(this);
@@ -117,7 +117,7 @@ public Module(QualifiedName name, Package<TruffleFile> pkg, TruffleFile sourceFi
    * @param literalSource the module's source.
    */
   public Module(QualifiedName name, Package<TruffleFile> pkg, String literalSource) {
-    this.literalSource = Rope.apply(literalSource);
+    this.sources = Sources.NONE.newWith(Rope.apply(literalSource), false);
     this.pkg = pkg;
     this.name = name;
     this.cache = new ModuleCache(this);
@@ -135,7 +135,7 @@ public Module(QualifiedName name, Package<TruffleFile> pkg, String literalSource
    * @param literalSource the module's source.
    */
   public Module(QualifiedName name, Package<TruffleFile> pkg, Rope literalSource) {
-    this.literalSource = literalSource;
+    this.sources = Sources.NONE.newWith(literalSource, false);
     this.pkg = pkg;
     this.name = name;
     this.cache = new ModuleCache(this);
@@ -152,6 +152,7 @@ public Module(QualifiedName name, Package<TruffleFile> pkg, Rope literalSource)
    *     belong to a package.
    */
   private Module(QualifiedName name, Package<TruffleFile> pkg) {
+    this.sources = Sources.NONE;
     this.name = name;
     this.scope = new ModuleScope(this);
     this.pkg = pkg;
@@ -177,14 +178,13 @@ public static Module empty(QualifiedName name, Package<TruffleFile> pkg) {
   /** Clears any literal source set for this module. */
   public void unsetLiteralSource() {
     this.isInteractive = false;
-    this.literalSource = null;
-    this.cachedSource = null;
+    this.sources = Sources.NONE;
     this.compilationStage = CompilationStage.INITIAL;
   }
 
   /** @return the literal source of this module. */
   public Rope getLiteralSource() {
-    return literalSource;
+    return sources.literalSource();
   }
 
   /**
@@ -193,18 +193,23 @@ public Rope getLiteralSource() {
    * @param source the module source.
    */
   public void setLiteralSource(String source) {
-    setLiteralSource(Rope.apply(source));
+    setLiteralSource(Rope.apply(source), null, null);
   }
 
   /**
    * Sets new literal sources for the module.
    *
    * @param source the module source.
    */
-  public void setLiteralSource(Rope source) {
-    this.literalSource = source;
+  public void setLiteralSource(Rope source, IR$Literal$Number change, model.TextEdit edit) {
+    if (this.scope != null && edit != null) {
+      if (this.scope.simpleUpdate(edit)) {
+        this.sources = this.sources.newWith(source, true);
+        return;
+      }
+    }
+    this.sources = this.sources.newWith(source, false);
     this.compilationStage = CompilationStage.INITIAL;
-    this.cachedSource = null;
     this.isInteractive = true;
   }
 
@@ -214,19 +219,14 @@ public void setLiteralSource(Rope source) {
    * @param file the module source file.
    */
   public void setSourceFile(TruffleFile file) {
-    this.literalSource = null;
-    this.sourceFile = file;
+    this.sources = Sources.NONE.newWith(file);
     this.compilationStage = CompilationStage.INITIAL;
-    this.cachedSource = null;
     this.isInteractive = false;
   }
 
   /** @return the location of this module. */
   public String getPath() {
-    if (sourceFile != null) {
-      return sourceFile.getPath();
-    }
-    return null;
+    return sources.getPath();
   }
 
   /**
@@ -259,17 +259,13 @@ public void ensureScopeExists() {
    * @throws IOException when the source comes from a file that can't be read.
    */
   public Source getSource() throws IOException {
-    if (cachedSource != null) {
-      return cachedSource;
+    final Source cached = sources.cachedSource();
+    if (cached != null) {
+      return cached;
     }
-    if (literalSource != null) {
-      cachedSource =
-          Source.newBuilder(LanguageInfo.ID, literalSource.characters(), name.toString()).build();
-    } else if (sourceFile != null) {
-      cachedSource = Source.newBuilder(LanguageInfo.ID, sourceFile).build();
-      literalSource = Rope.apply(cachedSource.getCharacters().toString());
-    }
-    return cachedSource;
+    Sources newSources = sources.ensureCachedSource(name);
+    sources = newSources;
+    return newSources.cachedSource();
   }
 
   private void compile(Context context) throws IOException {
@@ -350,7 +346,7 @@ public void setIndexed(boolean indexed) {
 
   /** @return the source file of this module. */
   public TruffleFile getSourceFile() {
-    return sourceFile;
+    return sources.sourceFile();
   }
 
   /** @return {@code true} if the module is interactive, {@code false} otherwise */
@@ -434,8 +430,7 @@ private static AtomConstructor getConstructor(ModuleScope scope, Object[] args)
     private static Module reparse(Module module, Object[] args, Context context)
         throws ArityException {
       Types.extractArguments(args);
-      module.cachedSource = null;
-      module.literalSource = null;
+      module.sources = module.sources.newWith(null, false);
       module.isInteractive = false;
       module.wasLoadedFromCache = false;
       try {
@@ -577,4 +572,83 @@ Object getMembers(boolean includeInternal) {
         MethodNames.Module.GET_ASSOCIATED_CONSTRUCTOR,
         MethodNames.Module.EVAL_EXPRESSION);
   }
+
+  private record Sources(
+          TruffleFile sourceFile,
+          AdaptiveRope ropeHolder,
+          Source cachedSource) {
+
+    static final Sources NONE = new Sources(null, new AdaptiveRope(null), null);
+
+    Sources newWith(TruffleFile f) {
+      return new Sources(f, ropeHolder(), cachedSource());
+    }
+
+    Sources newWith(Rope r, boolean keepCachedSource) {
+      if (keepCachedSource) {
+        if (r.characters().length() != literalSource().characters().length()) {
+          throw new IllegalStateException();
+        }
+        this.ropeHolder.update(r);
+        return this;
+      } else {
+        return new Sources(sourceFile(), new AdaptiveRope(r), null);
+      }
+    }
+
+    Sources ensureCachedSource(QualifiedName name) throws IOException {
+      if (cachedSource != null) {
+        return this;
+      }
+      if (literalSource() != null) {
+        var src = Source.newBuilder(LanguageInfo.ID, ropeHolder, name.toString()).build();
+        return new Sources(sourceFile, ropeHolder, src);
+      } else if (sourceFile != null) {
+        var src = Source.newBuilder(LanguageInfo.ID, sourceFile).build();
+        var lit = Rope.apply(src.getCharacters().toString());
+        return new Sources(sourceFile, new AdaptiveRope(lit), src);
+      }
+      throw new IllegalStateException();
+    }
+
+    String getPath() {
+      return sourceFile() == null ? null : sourceFile().getPath();
+    }
+
+    Rope literalSource() {
+      return ropeHolder.rope;
+    }
+
+    private static final class AdaptiveRope implements CharSequence {
+      Rope rope;
+
+      AdaptiveRope(Rope rope) {
+        this.rope = rope;
+      }
+
+      void update(Rope r) {
+        this.rope = r;
+      }
+
+      @Override
+      public int length() {
+        return rope.characters().length();
+      }
+
+      @Override
+      public char charAt(int index) {
+        return rope.characters().charAt(index);
+      }
+
+      @Override
+      public CharSequence subSequence(int start, int end) {
+        return rope.characters().subSequence(start, end);
+      }
+
+      @Override
+      public String toString() {
+        return rope.toString();
+      }
+    }
+  }
 }

engine/runtime/src/main/java/org/enso/interpreter/runtime/scope/ModuleScope.java

@@ -5,11 +5,17 @@
 import java.util.*;
 
 import com.oracle.truffle.api.interop.TruffleObject;
+import com.oracle.truffle.api.nodes.Node;
+import com.oracle.truffle.api.nodes.NodeUtil;
+import com.oracle.truffle.api.nodes.RootNode;
+import com.oracle.truffle.api.source.SourceSection;
+import org.enso.interpreter.node.expression.literal.IntegerLiteralNode;
 import org.enso.interpreter.runtime.Module;
 import org.enso.interpreter.runtime.callable.atom.AtomConstructor;
 import org.enso.interpreter.runtime.callable.function.Function;
 import org.enso.interpreter.runtime.error.RedefinedMethodException;
 import org.enso.interpreter.runtime.error.RedefinedConversionException;
+import org.enso.text.editing.model;
 
 /** A representation of Enso's per-file top-level scope. */
 public class ModuleScope implements TruffleObject {
@@ -295,4 +301,51 @@ public void reset() {
     conversions = new HashMap<>();
     polyglotSymbols = new HashMap<>();
   }
+
+  public boolean simpleUpdate(model.TextEdit edit) {
+    boolean f1 = updateFunctionsMap(edit, methods.values());
+    boolean f2 = updateFunctionsMap(edit, conversions.values());
+    return f1 || f2;
+  }
+
+  private boolean updateFunctionsMap(model.TextEdit edit, Collection<? extends Map<?, Function>> values) {
+    boolean found = false;
+    for (Map<?, Function> f : values) {
+      found |= updateFunctions(edit, f.values());
+    }
+    return found;
+  }
+
+  private boolean updateFunctions(model.TextEdit edit, Collection<Function> fns) {
+    boolean found = false;
+    for (Function f : fns) {
+      found |= updateFunction(edit, f);
+    }
+    return found;
+  }
+
+  private boolean updateFunction(model.TextEdit edit, Function f) {
+    return updateNode(edit, f.getCallTarget().getRootNode());
+  }
+
+  private boolean updateNode(model.TextEdit edit, Node node) {
+    boolean found = false;
+    if (node instanceof IntegerLiteralNode integerNode) {
+      SourceSection at = node.getSourceSection();
+      if (
+          at != null &&
+          at.getStartLine() - 1 == edit.range().start().line() &&
+          at.getStartColumn() - 1 == edit.range().start().character() &&
+          at.getEndLine() - 1 == edit.range().end().line() &&
+          at.getEndColumn() == edit.range().end().character()
+      ) {
+        found = true;
+        integerNode.updateConstant(edit.text());
+      }
+    }
+    for (Node n : NodeUtil.findNodeChildren(node)) {
+      found |= updateNode(edit, n);
+    }
+    return found;
+  }
 }