Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enso Integration with Ideal Graph Visualizer #3533

Merged
merged 23 commits into from
Jun 23, 2022

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Jun 16, 2022

Pull Request Description

This PR adds sources for Enso language support in IGV (and NetBeans). The support is based on TextMate grammar shown in the editor and registration of the Enso language so IGV can find it. Then this PR adds new GitHub Actions workflow file to build the project using Maven.

Important Notes

Checklist

Please include the following checklist in your PR:

  • Upload the resulting .nbm file somewhere
  • The documentation has to be written
  • All code conforms to the
    Java,
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach force-pushed the wip/jtulach/enso4igv-182388312 branch 2 times, most recently from 4e8d269 to 0ab2058 Compare June 16, 2022 15:01
Copy link
Contributor

@4e6 4e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great addition to Enso tools! Approving but I'd also like to see @mwu-tow approval on the CI part

.github/workflows/enso4igv.yml Outdated Show resolved Hide resolved
.github/workflows/enso4igv.yml Outdated Show resolved Hide resolved
@JaroslavTulach JaroslavTulach force-pushed the wip/jtulach/enso4igv-182388312 branch 2 times, most recently from 83e5ffa to 990436d Compare June 17, 2022 15:14
.github/workflows/enso4igv.yml Outdated Show resolved Hide resolved
.github/workflows/enso4igv.yml Outdated Show resolved Hide resolved
.github/workflows/enso4igv.yml Show resolved Hide resolved
tools/enso4igv/README.md Show resolved Hide resolved
tools/enso4igv/README.md Show resolved Hide resolved
tools/enso4igv/README.md Show resolved Hide resolved
tools/enso4igv/README.md Outdated Show resolved Hide resolved
tools/enso4igv/README.md Show resolved Hide resolved
#### Sieve of Eratosthenes Example

As an example you can download
[sieve.enso](https://github.com/jtulach/sieve/blob/5b32450da35415322e683bb9769aa45f0d71f1df/enso/sieve.enso)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd upload the file and link here from this repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. It would be good to include sieve.enso and make it part of daily executed code. That way we know the syntax is correct and the engine can still run the file. Where should I put the sieve.enso file then? CCing @hubertp , @jdunkerley , @kustosz - thank you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tools/enso4igv/examples ? Maybe there is something simpler we could add as well/instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It cannot be too simple program, it has to warmup. It could be any of the traditional benchmarks like N-body, Funkuch, etc. However I doubt they are simpler.

Anyway let's address this later. I am already behind the schedule and properly solving this (e.g. making sure the file is tested on each change in engine) requires additional thoughts.

tools/enso4igv/README.md Outdated Show resolved Hide resolved
Co-authored-by: Michał Wawrzyniec Urbańczyk <mwu-tow@gazeta.pl>
Copy link
Contributor

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2022-06-22 15-24-03
It works!

Btw maybe enso.png should be rather placed in some common directory with other icons resources (somewhere in gui?)

tools/enso4igv/README.md Show resolved Hide resolved
tools/enso4igv/README.md Outdated Show resolved Hide resolved
tools/enso4igv/README.md Outdated Show resolved Hide resolved
tools/enso4igv/README.md Outdated Show resolved Hide resolved
#### Sieve of Eratosthenes Example

As an example you can download
[sieve.enso](https://github.com/jtulach/sieve/blob/5b32450da35415322e683bb9769aa45f0d71f1df/enso/sieve.enso)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tools/enso4igv/examples ? Maybe there is something simpler we could add as well/instead?

tools/enso4igv/README.md Outdated Show resolved Hide resolved
tools/enso4igv/README.md Outdated Show resolved Hide resolved
tools/enso4igv/README.md Outdated Show resolved Hide resolved
tools/enso4igv/README.md Outdated Show resolved Hide resolved
@JaroslavTulach JaroslavTulach self-assigned this Jun 22, 2022
@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Jun 22, 2022
@mergify mergify bot merged commit 479f74c into develop Jun 23, 2022
@mergify mergify bot deleted the wip/jtulach/enso4igv-182388312 branch June 23, 2022 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants