Short hand version for order_by
#3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
commented
Aug 11, 2022
radeusgd
commented
Aug 11, 2022
| type By_Column (columns : Vector Sort_Column.Column) | ||
| type By_Name (columns : Vector (Sort_Column.Name | Text)) (matcher:Matcher=Text_Matcher) | ||
| type By_Index (columns : Vector (Sort_Column.Index | Integer)) | ||
| type By_Column (columns : Vector (Sort_Column.Column | Column)) |
There was a problem hiding this comment.
It is a bit worrisome to me that the Column type actually does not exist! So we are lying a bit here and it may bite us once we have some validation of these type signatures.
Well - we have a Column type but there is one for Table and another for Database and without interfaces we cannot really relate them. In the absence of typechecking, maybe we can go for Table.Column, but in the longer term we probably need to replace this with some Column interface. This is a common issue across the Table/Database library.
There was a problem hiding this comment.
I agree - this is a common issue and one the revised type system will need to resolve.
Pinging @ekmett - one to consider on the stuff you are working on.
radeusgd
force-pushed
the
wip/radeusgd/order-by-shorthand-182868310
branch
from
cec3c83
to
1a1dd3d
Compare
jdunkerley
force-pushed
the
wip/radeusgd/order-by-shorthand-182868310
branch
from
1a1dd3d
to
00573ab
Compare
jdunkerley
approved these changes
Aug 16, 2022
jdunkerley
force-pushed
the
wip/radeusgd/order-by-shorthand-182868310
branch
from
00573ab
to
3d9af6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Implements https://www.pivotaltracker.com/story/show/182868310
Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.