Wip/mk/statics #3740
Wip/mk/statics #3740
Conversation
kustosz
requested review from
jdunkerley,
radeusgd,
4e6 and
JaroslavTulach
as code owners
| foreign js my_method self = """ | ||
| return this.a + this.b; |
There was a problem hiding this comment.
The self feels odd - I thought we had a special case for this here?
There was a problem hiding this comment.
I don't think we do? It doesn't work anyway, should be tackled in a separate issue if you think we need it.
There was a problem hiding this comment.
No special cases for JavaScript outside of EpbLanguage, please!
| } | ||
|
|
||
| @Specialization | ||
| Text doType(Type type) { |
There was a problem hiding this comment.
Meta.get_constructor_name works on Type!? Is the get_constructor_name still correct?
There was a problem hiding this comment.
Left for backwards compatibility – optimally we should get rid of this, but there is still code in the stdlib that depends on some things being atoms.
| @@ -158,7 +158,7 @@ private void generateQualifiedAccessor() { | |||
| null, | |||
| new FunctionSchema( | |||
| new ArgumentDefinition(0, "self", ArgumentDefinition.ExecutionMode.EXECUTE))); | |||
| definitionScope.registerMethod(definitionScope.getAssociatedType(), this.name, function); | |||
| definitionScope.registerMethod(type.getEigentype(), this.name, function); | |||
There was a problem hiding this comment.
What is eigentype? Own type?
There was a problem hiding this comment.
Yeah, the type of this type – where statics live. If you can think of a better name, we can switch
| @@ -170,4 +227,16 @@ boolean isNull(@CachedLibrary("this") InteropLibrary self) { | |||
| public String toString() { | |||
| return toDisplayString(true); | |||
| } | |||
|
|
|||
| public Type getEigentype() { | |||
There was a problem hiding this comment.
There already is Type getType()...
There was a problem hiding this comment.
Yes, but that is for library usage, and given this is already a type, and there's also it's supertype, I want to be super clear with the getters.
Pull Request Description
Makes statics static. A type and its instances have different methods defined on them, as it should be. Constructors are now scoped in types, and can be imported/exported.
Important Notes
The method of fixing stdlib chosen here is to just not. All the conses are exported to make all old code work. All such instances are marked with
TODO Dubious constructor exportso that it can be found and fixed.Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.