Implement Lazy Text Visualisation. #3910

MichaelMauderer · 2022-11-24T22:26:18Z

Pull Request Description

Implements #183453466.

Peek.2022-11-24.15-24.mp4

Important Notes

the best laziness is used for Text type, which makes use of its internal representation to send data
any type will first compute its default string representation and then send the content of that lazy to the IDE
special handling of files and their content will be implemented in the future
size of the displayed text can be updated dynamically based on best effort information: if the backend does not yet know the full width/height of the text, it can update the IDE at any time and this will be handled gracefully by updating the scrollbar position and sizes.

Checklist

Please include the following checklist in your PR:

The documentation has been updated if necessary.
All code conforms to the
Scala,
Java,
and
Rust
style guides.
All code has been tested:
- Unit tests have been written where possible.
- If GUI codebase was changed: Enso GUI was tested when built using BOTH
  ./run ide build and ./run ide watch.

jdunkerley · 2022-11-25T14:26:17Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Any.enso

+    ## UNSTABLE
+       ADVANCED
+
+       Returns the data requested to render a lazy view of the default visualisation.
+    to_lazy_visualization_data : Text
+    to_lazy_visualization_data self text_window_position text_window_size chunk_size =
+        text = self.to_default_visualization_data
+        min_length_for_laziness = chunk_size * (text_window_size.at 0) * (text_window_size.at 1)
+        if text.length <= min_length_for_laziness then text else
+            get_lazy_visualisation_text_window text text_window_position text_window_size chunk_size


Could we put these as an extension method in Standard.Visualisation.

The circular dependency this introduces into the library structure is not great. We will also move to_default_visualisation there as well soon.

Suggested change

## UNSTABLE

ADVANCED

Returns the data requested to render a lazy view of the default visualisation.

to_lazy_visualization_data : Text

to_lazy_visualization_data self text_window_position text_window_size chunk_size =

text = self.to_default_visualization_data

min_length_for_laziness = chunk_size * (text_window_size.at 0) * (text_window_size.at 1)

if text.length <= min_length_for_laziness then text else

get_lazy_visualisation_text_window text text_window_position text_window_size chunk_size

## UNSTABLE

ADVANCED

Returns the data requested to render a lazy view of the default visualisation.

Any.to_lazy_visualization_data : Vector Integer -> Vector Integer -> Text

Any.to_lazy_visualization_data self text_window_position text_window_size chunk_size =

text = self.to_default_visualization_data

min_length_for_laziness = chunk_size * (text_window_size.first) * (text_window_size.second)

if text.length <= min_length_for_laziness then text else

get_lazy_visualisation_text_window text text_window_position text_window_size chunk_size

By all means put in Main.enso within Standard.Visualisation for now. We can organise tidying up within library team.

Makes sense. Moving this around.

jdunkerley · 2022-11-25T14:27:01Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Any.enso

@@ -7,6 +7,7 @@ import project.Meta
 from project.Data.Json import all
 from project.Data.Boolean import Boolean, True, False
 from project.Error.Common import Error, dataflow_error_handler
+from Standard.Visualization.Text import get_lazy_visualisation_text_window


This introduces a circular dependency between Visualisation and Base.

jdunkerley · 2022-11-25T14:27:15Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text.enso

@@ -4,6 +4,7 @@ import project.Meta

 from project.Data.Boolean import Boolean, True, False
 from project.Error.Common import Error, Type_Error_Data
+from Standard.Visualization.Text import get_lazy_visualisation_text_window


jdunkerley · 2022-11-25T14:28:41Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Any.enso

+        text = self.to_default_visualization_data
+        min_length_for_laziness = chunk_size * (text_window_size.at 0) * (text_window_size.at 1)
+        if text.length <= min_length_for_laziness then text else
+            get_lazy_visualisation_text_window text text_window_position text_window_size chunk_size


Missing new line at end of file.

jdunkerley · 2022-11-25T14:29:25Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text.enso

+    ## UNSTABLE
+       ADVANCED
+           Returns the data requested to render a lazy view of the text.
+    to_lazy_visualization_data : Text
+    to_lazy_visualization_data self text_window_position text_window_size chunk_size =
+        get_lazy_visualisation_text_window self text_window_position text_window_size chunk_size


Suggested change

## UNSTABLE

ADVANCED

Returns the data requested to render a lazy view of the text.

to_lazy_visualization_data : Text

to_lazy_visualization_data self text_window_position text_window_size chunk_size =

get_lazy_visualisation_text_window self text_window_position text_window_size chunk_size

## UNSTABLE

ADVANCED

Returns the data requested to render a lazy view of the text.

Text.to_lazy_visualization_data : Vector Integer -> Vector Integer -> Text

Text.to_lazy_visualization_data self text_window_position text_window_size chunk_size =

get_lazy_visualisation_text_window self text_window_position text_window_size chunk_size

jdunkerley · 2022-11-25T14:29:44Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text.enso

+           Returns the data requested to render a lazy view of the text.
+    to_lazy_visualization_data : Text
+    to_lazy_visualization_data self text_window_position text_window_size chunk_size =
+        get_lazy_visualisation_text_window self text_window_position text_window_size chunk_size


Missing new line at end of file.

jdunkerley · 2022-11-25T14:31:34Z

test/Visualization_Tests/src/Lazy_Text_Spec.enso

+
+spec = Test.group "By coordinates" <|
+    Test.specify "Get correct chunks" <|
+        (Preprocessor.lazy_preprocessor sample_text_multi_line [0,0] [1,1] 5).should_equal '{"chunks":"[[[0, 0], \\"ABCDE\\"]]","lines":2,"max_line_length":19}'


Could consider using Pair instead of Vector for the API: Pair.new 0 0 instead of [0, 0] but as an internal function am happy with Vector or an Array if easier.

jdunkerley · 2022-11-25T14:40:49Z

distribution/lib/Standard/Visualization/0.0.0-dev/src/Text.enso

+    chunks = coordinates.map (ix -> format_chunk ix (get_text_chunk ix))
+    data_string = format_chunks chunks
+    lines = text.lines.length
+    active_lines = y_range.map (line_ix -> text.lines.at line_ix)


Suggested change

active_lines = y_range.map (line_ix -> text.lines.at line_ix)

active_lines = y_range.map text.lines.at

jdunkerley · 2022-11-25T14:47:05Z

distribution/lib/Standard/Visualization/0.0.0-dev/src/Text.enso

+    lines = text.lines.length
+    active_lines = y_range.map (line_ix -> text.lines.at line_ix)


Should cache text.lines as recalculating will be costly.

Suggested change

lines = text.lines.length

active_lines = y_range.map (line_ix -> text.lines.at line_ix)

text_lines = text.lines

lines = text_lines.length

active_lines = y_range.map text_lines.at

radeusgd · 2022-11-25T11:07:55Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Any.enso

+        text = self.to_default_visualization_data
+        min_length_for_laziness = chunk_size * (text_window_size.at 0) * (text_window_size.at 1)
+        if text.length <= min_length_for_laziness then text else
+            get_lazy_visualisation_text_window text text_window_position text_window_size chunk_size


Suggested change

get_lazy_visualisation_text_window text text_window_position text_window_size chunk_size

get_lazy_visualisation_text_window text text_window_position text_window_size chunk_size

Please add a newline at the end of the file.

radeusgd · 2022-11-25T11:10:11Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Any.enso

+       ADVANCED
+
+       Returns the data requested to render a lazy view of the default visualisation.
+    to_lazy_visualization_data : Text


What are the types of the arguments? The signature suggest that this method takes no arguments and just returns a Text, but it does seem to take arguments.

radeusgd · 2022-11-25T11:11:37Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text.enso

+    to_lazy_visualization_data : Text
+    to_lazy_visualization_data self text_window_position text_window_size chunk_size =
+        get_lazy_visualisation_text_window self text_window_position text_window_size chunk_size


Shouldn't this logic be guarded on text length in the same way as for Any? Seems like computing the window is an overkill for very short texts which may appear relatively often.

radeusgd · 2022-11-25T11:13:06Z

distribution/lib/Standard/Visualization/0.0.0-dev/src/Text.enso

+
+from Standard.Base.Data.Text.Extensions import slice_text
+
+## Return a sub-window of a string. The window is defined by line/chunk coordinates. The siz of


Suggested change

## Return a sub-window of a string. The window is defined by line/chunk coordinates. The siz of

## Return a sub-window of a string. The window is defined by line/chunk coordinates. The size of

radeusgd · 2022-11-25T11:13:19Z

...gui/view/graph-editor/src/builtin/visualization/native/lazy_text_visualization/grid_cache.rs

@@ -0,0 +1,203 @@
+//! A cache that stores a grid of items. The cache contains a grid of items, and aa padding around


Suggested change

//! A cache that stores a grid of items. The cache contains a grid of items, and aa padding around

//! A cache that stores a grid of items. The cache contains a grid of items, and a padding around

radeusgd · 2022-11-25T11:15:53Z

test/Visualization_Tests/src/Lazy_Text_Spec.enso

+    ABCDEFGHIJKLMNOPQRS
+    1234567890
+
+spec = Test.group "By coordinates" <|


Suggested change

spec = Test.group "By coordinates" <|

spec = Test.group "Lazy Text Visualization" <|

The current approach will show the following report in our test runs:

By coordinates: - Get correct chunks

it is a bit hard to read what test that refers to, so I think it would be good to rename to make it clearer.

Also in specify we usually start with 'should', but it is not a requirement.

radeusgd · 2022-11-25T11:16:30Z

test/Visualization_Tests/src/Lazy_Text_Spec.enso

+    Test.specify "Get correct chunks" <|
+        (Preprocessor.lazy_preprocessor sample_text_multi_line [0,0] [1,1] 5).should_equal '{"chunks":"[[[0, 0], \\"ABCDE\\"]]","lines":2,"max_line_length":19}'
+        (Preprocessor.lazy_preprocessor sample_text_multi_line [1,1] [1,1] 5).should_equal '{"chunks":"[[[1, 1], \\"67890\\"]]","lines":2,"max_line_length":10}'


Can we have a test where more than 1 chunk is returned?

(If that is even to be supported, but looking at the code it seems to be. I think then it should be tested)

radeusgd · 2022-11-25T11:17:49Z

distribution/lib/Standard/Visualization/0.0.0-dev/src/Text.enso

+make_grid_visualisation_response chunks lines max_line_length =
+    (Json.from_pairs [["chunks", chunks], ["lines", lines], ["max_line_length", max_line_length]]).to_text
+
+## Return a chunk of text from a string. The chunk is defined by a its size and a line/chunk index


Suggested change

## Return a chunk of text from a string. The chunk is defined by a its size and a line/chunk index

## Return a chunk of text from a string. The chunk is defined by its size and a line/chunk index

radeusgd · 2022-11-25T11:18:25Z

distribution/lib/Standard/Visualization/0.0.0-dev/src/Text.enso

+   coordinate.
+get_item_from text chunk_size index =
+    line_ix = index.at 1
+    if line_ix > text.lines.length then "" else


If we get out of bounds shouldn't we return some meaningful flag? Like a Nothing or a dataflow error?

This was intentional because all the visualization will just want to know that there is nothing to display. We could try to omit the value for the requested cell, but then it will be harder to differentiate between "I have requested this and know that there is nothing to display" and "I do not know the value to display".

I guess we could also return null (in JSON) and this would probably be the nicer design for potential optimizations on the IDE side. So I'm changing it to that.

wdanilo · 2022-11-28T10:41:50Z

app/gui/view/debug_scene/text-grid-visualization/src/lib.rs

@@ -94,7 +95,7 @@ fn init(app: &Application) {
        let camera = scene.camera();
        let navigator = Navigator::new(scene, &camera);

-        let text_source = sample_text();


refactor this constant to a variable with a descriptive name pls.

wdanilo · 2022-11-28T10:42:33Z

app/gui/view/graph-editor/src/builtin/visualization/native/lazy_text_visualization.rs

@@ -1,12 +1,19 @@
-//! Example visualisation showing the provided data as text.
+//! Lazy text visualisation that can show text based data from the backend.


I don't think we need to name the visualization as "lazy_text_visualization". It is just a text visualization. The fact that it's lazy is its internal thing.

Also, what is "text based data"? Can it show non-text based data, like tables, that can be printed to text?

The visualization shows (at the stage of this PR) only text (or JSON data rendered as text). Conversion to text or JSON, happens on the engine side.

wdanilo · 2022-11-28T10:44:15Z

app/gui/view/graph-editor/src/builtin/visualization/native/lazy_text_visualization.rs

-        fn set_position_and_size(&self, pos: &Vector2, size: &Vector2) {
-            self.text.set_position_xy(*pos);
+/// Number of characters that can be displayed in one grid cell. Also referred to as `chunk`.
+const CHARS_PER_CELL: f32 = 10.0;


Coudl you expand this docs, please? For example, why this number was chosen? Can we choose smaller / bigger one? Also, what happens if you put non-jnteger number here?

Updated, and changed to usize. The value was first used as f32 for size computations, but usize makes more sense.

wdanilo · 2022-11-28T10:44:43Z

app/gui/view/graph-editor/src/builtin/visualization/native/lazy_text_visualization.rs

+const CHARS_PER_CELL: f32 = 10.0;
+/// Extra chunks to load around the visible grid to ensure smooth scrolling. Extra chunks are
+/// loaded in each direction around the visible grid. So a value of 5 with a base grid of 20x10 will
+/// load 25x15 grid.


So is a "chunk" = "line"?

chunk is part of a line, but not a full line. I've added more explanation in the module description and the docs of the CHARS_PER_CHUNK constant.

wdanilo · 2022-11-28T10:45:28Z

app/gui/view/graph-editor/src/builtin/visualization/native/lazy_text_visualization.rs

@@ -207,44 +133,34 @@ impl<T: TextProvider> Model<T> {
    fn set_size(&self, size: Vector2) {
        self.scroll_bar_horizontal.set_position_y(-size.y / 2.0);
        self.scroll_bar_horizontal.set_length(size.x);
+        self.scroll_bar_horizontal
+            .mod_position_y(|y| y + (scrollbar::WIDTH - scrollbar::PADDING) / 2.0);


FYI, after merging develop, this needs to be changed to mod_y.

wdanilo · 2022-11-28T11:10:05Z

.../view/graph-editor/src/builtin/visualization/native/lazy_text_visualization/text_provider.rs

+                Ok(LazyGridData { chunks, line_count, longest_line })
+            } else {
+                let data_str = serde_json::to_string_pretty(&*content);
+                let data_str = data_str.unwrap_or_else(|e| format!("<Cannot render data: {}>", e));


missing dot

wdanilo · 2022-11-28T11:10:37Z

.../view/graph-editor/src/builtin/visualization/native/lazy_text_visualization/text_provider.rs

+                    .unwrap_or_default()
+                    .unwrap_or_default();


In case of improper data, we are getting defaults here, but we do not emit a warning, which can hide errors - am I right?

wdanilo · 2022-11-28T11:11:19Z

.../view/graph-editor/src/builtin/visualization/native/lazy_text_visualization/text_provider.rs

+        let chunks = content
+            .lines()
+            .enumerate()
+            .flat_map(|(line_ix, line)| {
+                line.chars()
+                    .chunks(CHARS_PER_CELL as usize)
+                    .into_iter()
+                    .enumerate()
+                    .map(move |(chunk_ix, chunk)| {
+                        let chunk = chunk.collect::<String>();
+                        let pos = GridPosition::new(chunk_ix as i32, line_ix as i32);
+                        (pos, chunk)
+                    })
+                    .collect_vec()
+            })
+            .collect();
+        let line_count = content.lines().count() as u32;


Can we split it into a few lines with well named vars, please?

wdanilo · 2022-11-28T11:25:38Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Any.enso

+       ADVANCED
+
+       Returns the data requested to render a lazy view of the default visualisation.
+    to_lazy_visualization_data : Text


I'm not sure if we should explicitly tell here that it is for "lazy" visualization. All of our visualizations should be lazy, so maybe it should be just named "to_visualization_data"?

wdanilo · 2022-11-28T11:27:56Z

distribution/lib/Standard/Visualization/0.0.0-dev/src/Text.enso

+
+## Format a chunk of text and meta information for the lazy visualisation.
+make_grid_visualisation_response chunks lines max_line_length =
+    (Json.from_pairs [["chunks", chunks], ["lines", lines], ["max_line_length", max_line_length]]).to_text


these names, like "chunks" or "lines" are hardcoded here. Can we instead just serialize an Enso struct instead of hardcoding them?

wdanilo

Beautiful <3

…Column_Grid_View_Text_Visualization_with_the_IDE_and_Engine_#183453466 # Conflicts: # CHANGELOG.md # app/gui/view/graph-editor/src/builtin/visualization/native/text_grid.rs

…Column_Grid_View_Text_Visualization_with_the_IDE_and_Engine_#183453466 # Conflicts: # CHANGELOG.md

…Column_Grid_View_Text_Visualization_with_the_IDE_and_Engine_#183453466 # Conflicts: # CHANGELOG.md # distribution/lib/Standard/Visualization/0.0.0-dev/src/Main.enso # distribution/lib/Standard/Visualization/0.0.0-dev/src/Preprocessor.enso

MichaelMauderer · 2022-12-14T12:34:22Z

@jdunkerley @radeusgd Could you re-review?

…Column_Grid_View_Text_Visualization_with_the_IDE_and_Engine_#183453466

wdanilo · 2023-01-16T09:36:07Z

app/gui/view/graph-editor/src/builtin/visualization/native/text_visualization.rs

+        let clipping_div = web::document.create_div_or_panic();
+        let clipping_div = DomSymbol::new(&clipping_div);
+        let dom_entry_root = web::document.create_div_or_panic();
+        let size = default();
+        let text_provider = default();
+
+        clipping_div.set_style_or_warn("overflow", "hidden");
+        dom_entry_root.set_style_or_warn("position", "absolute");
+        scene.dom.layers.front.manage(&clipping_div);
+        root.add_child(&clipping_div);
+        clipping_div.append_or_warn(&dom_entry_root);


This is super complex. Without proper explanation it is not understandable. Please refactor to a well documented function

wdanilo · 2023-01-16T09:38:44Z

app/gui/view/graph-editor/src/builtin/visualization/native/text_visualization.rs

+            on_data_update <- frp.send_data.constant(());
+            text_grid.request_model_for_visible_entries <+ any(on_data_update,init);
+
+            // === Visualisation API Inputs ===
+
+            eval frp.set_size  ((size) model.set_size(*size));
+
+
+            // === Text Grid API ===
+
+            requested_entry <- text_grid.model_for_entry_needed.map2(&text_grid.grid_size,
+                f!([model]((row, col), _grid_size) {
+                    let text = model.get_string_for_cell(*row,*col);
+                    let model = grid_view_entry::Model{text};
+                    (*row, *col, model)
+                })
+            );
+            text_grid.model_for_entry <+ requested_entry;


This is really long FRP definition. Please refactor it to a few, well named and well-documented functions. See lib/rust/ensogl/component/text/src/component/text.rs (function Text::init for reference)

wdanilo · 2023-01-16T09:40:01Z

app/gui/view/graph-editor/src/builtin/visualization/native/text_visualization.rs

+
+
+// =================================
+// === Text Processing Utilities ===


This title is very generic. In fact, anything can be considered an "utility". What we are doing here is measuring the glyph size.

wdanilo · 2023-01-16T09:41:02Z

app/gui/view/graph-editor/src/builtin/visualization/native/text_visualization.rs

+    // This extends the lifetime of the closure which is what we want here. Otherwise, the closure
+    // would be destroyed and the callback cannot be called.
+    #[allow(clippy::forget_non_drop)]
+    mem::forget(closure);


Don't use mem:forget if you do not need to. You can store the closure in network instead (it has a function for storing such things). Even better would be to store it in the visualization struct itself, so it can be properly documented. Using mem::forget should be the absolutely last resort.

wdanilo · 2023-01-16T09:42:29Z

app/gui/view/graph-editor/src/builtin/visualization/native/text_visualization/grid_cache.rs

+// =================
+// === GridCache ===
+// =================
+


wdanilo · 2023-01-16T09:44:43Z

app/gui/view/graph-editor/src/builtin/visualization/native/text_visualization/text_provider.rs

+        let y = line as i32;
+        let x = chunk_index as i32;
+        let result = self.text_cache.borrow_mut().get_item(Vector2::new(x, y));
+        // self.register_access.emit(());


commented code

wdanilo · 2023-01-16T09:45:17Z

app/gui/view/graph-editor/src/builtin/visualization/native/text_visualization/text_provider.rs

+/// Crate a preprocessor configuration for the lazy text preprocessor.
+fn lazy_text_preprocessor(


Both the documentation and the function name are mysterious for me. Could you describe it better, please? Also, the "laziness" should be explained here.

wdanilo · 2023-01-16T09:45:56Z

app/gui/view/graph-editor/src/builtin/visualization/native/text_visualization/text_provider.rs

+    grid_position: GridPosition,
+    grids_size: GridSize,
+) -> PreprocessorConfiguration {
+    let p = PreprocessorConfiguration::new(


p is not the best name for a variable

Changed. This was left over debug code.

wdanilo · 2023-01-16T09:46:46Z

app/gui/view/graph-editor/src/builtin/visualization/native/text_visualization/text_provider.rs

+}
+
+
+#[cfg(test)]


missing section

wdanilo · 2023-01-16T09:47:40Z

app/gui/view/graph-editor/src/component/visualization/registry.rs

@@ -100,7 +100,7 @@ impl Registry {

    /// Add default visualizations to the registry.
    pub fn add_default_visualizations(&self) {
-        self.add(builtin::visualization::native::RawText::definition());
+        self.add(builtin::visualization::native::text_visualization::lazy_text_visualisation());


I was writing about it in the previous PR review. All our visualisations should be "lazy", so mentioning "lazy" in any name doesnt make sense. This should be "text_visualization" instead. Please fix here and in other similar places.

Missed this one. Changed.

wdanilo · 2023-01-18T06:12:58Z

Cargo.toml

@@ -32,7 +32,7 @@ default-members = ["app/gui", "lib/rust/*"]
 console_error_panic_hook = { git = 'https://github.com/enso-org/console_error_panic_hook' }

 [profile.dev]
-opt-level = 0
+opt-level = 1


Is this intentional change?

wdanilo · 2023-01-18T06:13:59Z

app/gui/view/graph-editor/src/builtin/visualization/native/text_visualization/grid_cache.rs

+// === Tests ===
+// =============
+
+


…Column_Grid_View_Text_Visualization_with_the_IDE_and_Engine_#183453466

MichaelMauderer added 3 commits November 24, 2022 15:14

Implement Lazy Text Visualisation.

76f19a3

Update changelog.

345ec2d

Fix formatting.

b25733b

MichaelMauderer self-assigned this Nov 24, 2022

Remove old tests.

f2d3bc7

MichaelMauderer marked this pull request as ready for review November 24, 2022 23:03

MichaelMauderer requested review from jdunkerley, radeusgd, wdanilo and farmaazon as code owners November 24, 2022 23:03

jdunkerley requested changes Nov 25, 2022

View reviewed changes

radeusgd reviewed Nov 26, 2022

View reviewed changes

wdanilo requested changes Nov 28, 2022

View reviewed changes

Review feedback.

8328d9e

MichaelMauderer requested review from wdanilo, jdunkerley and radeusgd December 1, 2022 15:29

wdanilo approved these changes Dec 2, 2022

View reviewed changes

MichaelMauderer added 3 commits December 2, 2022 11:46

Merge branch 'develop' into wip/michaelmauderer/Integrate_the_Single_…

a62f9c8

…Column_Grid_View_Text_Visualization_with_the_IDE_and_Engine_#183453466 # Conflicts: # CHANGELOG.md # app/gui/view/graph-editor/src/builtin/visualization/native/text_grid.rs

Update EnsoGL API.

c0e4ea2

Merge branch 'develop' into wip/michaelmauderer/Integrate_the_Single_…

10cbcb9

…Column_Grid_View_Text_Visualization_with_the_IDE_and_Engine_#183453466 # Conflicts: # CHANGELOG.md

MichaelMauderer requested review from mwu-tow and kazcw as code owners December 6, 2022 13:09

MichaelMauderer added 3 commits December 6, 2022 13:29

Fix initialisation.

9c39ecc

Fix object hierarchy vs DOM object issue.

a81e940

MichaelMauderer added 3 commits December 15, 2022 13:45

Merge branch 'develop' into wip/michaelmauderer/Integrate_the_Single_…

ef272f0

…Column_Grid_View_Text_Visualization_with_the_IDE_and_Engine_#183453466

Add missing import.

c4bb80d

Bump wasm size.

7db12fc

wdanilo requested changes Jan 16, 2023

View reviewed changes

MichaelMauderer added 8 commits January 17, 2023 12:22

Refactor initialisation.

614d181

Refactor and better document initialisation.

be06fcd

Refactor frp initialisation.

3760aa0

Clarify section title.

dae08b2

Remove use of mem::forget.

0fe756d

Remove mention of "lazy_text".

a9e9436

fmt.

8396cfa

fmt.

91cefa5

MichaelMauderer requested a review from wdanilo January 17, 2023 13:34

wdanilo approved these changes Jan 18, 2023

View reviewed changes

MichaelMauderer and others added 6 commits January 18, 2023 12:06

Update Cargo.toml

a520f65

Update grid_cache.rs

040373f

Fix wasm closure being dropped to early.

e575dd7

Correctly apply updates for empty chunks.

61b16f9

Fix text overlapping vis selector.

13e2276

Fix empty chunks not being updated.

7f3c4e0

MichaelMauderer force-pushed the wip/michaelmauderer/Integrate_the_Single_Column_Grid_View_Text_Visualization_with_the_IDE_and_Engine_#183453466 branch from d6c5ae6 to 7f3c4e0 Compare January 20, 2023 13:05

MichaelMauderer and others added 4 commits January 23, 2023 13:12

Fix data update bug and resolve lint errors.

bbc5bca

Fix data invalidation on full update.

088fbfc

Merge branch 'develop' into wip/michaelmauderer/Integrate_the_Single_…

086a8da

…Column_Grid_View_Text_Visualization_with_the_IDE_and_Engine_#183453466

Fix js mock type issue.

709c679

MichaelMauderer added CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge labels Jan 24, 2023

mergify bot added 3 commits January 24, 2023 13:03

Merge branch 'develop' into wip/michaelmauderer/Integrate_the_Single_…

b7b0b10

…Column_Grid_View_Text_Visualization_with_the_IDE_and_Engine_#183453466

Merge branch 'develop' into wip/michaelmauderer/Integrate_the_Single_…

3044132

…Column_Grid_View_Text_Visualization_with_the_IDE_and_Engine_#183453466

Merge branch 'develop' into wip/michaelmauderer/Integrate_the_Single_…

badcec2

…Column_Grid_View_Text_Visualization_with_the_IDE_and_Engine_#183453466

mergify bot merged commit 38906b3 into develop Jan 24, 2023

mergify bot deleted the wip/michaelmauderer/Integrate_the_Single_Column_Grid_View_Text_Visualization_with_the_IDE_and_Engine_#183453466 branch January 24, 2023 20:55

wdanilo mentioned this pull request Feb 6, 2023

Integrate the Single Column Grid View Text Visualization with the IDE and Engine #4906

Closed

	active_lines = y_range.map (line_ix -> text.lines.at line_ix)
	active_lines = y_range.map text.lines.at

		lines = text.lines.length
		active_lines = y_range.map (line_ix -> text.lines.at line_ix)

-    lines = text.lines.length
-    active_lines = y_range.map (line_ix -> text.lines.at line_ix)
+    text_lines = text.lines
+    lines = text_lines.length
+    active_lines = y_range.map text_lines.at

	get_lazy_visualisation_text_window text text_window_position text_window_size chunk_size
	get_lazy_visualisation_text_window text text_window_position text_window_size chunk_size


		from Standard.Base.Data.Text.Extensions import slice_text

		## Return a sub-window of a string. The window is defined by line/chunk coordinates. The siz of

		@@ -0,0 +1,203 @@
		//! A cache that stores a grid of items. The cache contains a grid of items, and aa padding around

	spec = Test.group "By coordinates" <\|
	spec = Test.group "Lazy Text Visualization" <\|

	## Return a chunk of text from a string. The chunk is defined by a its size and a line/chunk index
	## Return a chunk of text from a string. The chunk is defined by its size and a line/chunk index

		@@ -1,12 +1,19 @@
		//! Example visualisation showing the provided data as text.
		//! Lazy text visualisation that can show text based data from the backend.



		// =================================
		// === Text Processing Utilities ===

		/// Crate a preprocessor configuration for the lazy text preprocessor.
		fn lazy_text_preprocessor(

Implement Lazy Text Visualisation. #3910

Implement Lazy Text Visualisation. #3910

Conversation

MichaelMauderer commented Nov 24, 2022 • edited Loading

Pull Request Description

Important Notes

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wdanilo left a comment

Choose a reason for hiding this comment

MichaelMauderer commented Dec 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MichaelMauderer commented Nov 24, 2022 •

edited

Loading