Add a shortcut for interrupting the program #3967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdanilo
approved these changes
Dec 12, 2022
Comment on lines
+301
to
+306
| fn restart(&self) -> BoxFuture<FallibleResult> { | ||
| async move { | ||
| self.language_server.client.recompute(&self.id).await?; | ||
| Ok(()) | ||
| } | ||
| .boxed_local() |
There was a problem hiding this comment.
- is restarting automatically interrupting?
- Is interrupting pausing until its restarted? It should.
4e6
requested review from
MichaelMauderer,
farmaazon and
mwu-tow
as code owners
farmaazon
approved these changes
Dec 12, 2022
| /// Execution Context handle, its call stack top contains `graph`'s definition. | ||
| execution_ctx: model::ExecutionContext, | ||
| pub execution_ctx: model::ExecutionContext, |
There was a problem hiding this comment.
This field was private for a reason: otherwise, someone could manually push a frame there without changing the graph field, which should always point to the definition on top of the frame.
Please, make it private and add interrupt and restart methods to this handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add shortcuts for interrupting and restarting the program execution.
Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.