Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Date, Time_Of_Day and Date_Time support to Excel IO #3997

Merged
merged 5 commits into from
Dec 20, 2022
Merged

Adds Date, Time_Of_Day and Date_Time support to Excel IO #3997

merged 5 commits into from
Dec 20, 2022

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Dec 20, 2022 •
edited
Loading

Pull Request Description

  • Allow date time inputs from Excel.
  • Enables disabled test.
  • Fix for Map.==.
  • Allow nulls in crosstab name.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Dec 20, 2022
@jdunkerley
PR Comments.
0c701f6 
Deal with JDBC issue.
@mergify mergify bot merged commit 579d3fc into develop Dec 20, 2022
@mergify mergify bot deleted the wip/jd/quick-fixes branch December 20, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

Assignees
No one assigned
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdunkerley @radeusgd