Add a shortcut to toggle the visibility of private components in the component browser #5582
Conversation
…0' of github.com:enso-org/enso into wip/galin-enso/exclude-private-methods-from-cb-184215360
…isibility-184215360
The navigator buttons glitch should be fixed now. |
app/gui/src/presenter/searcher.rs
Outdated
| searcher_input_on_visibility_toggle <- | ||
| model.view.searcher_input_changed.sample(&reloading_action_list_done); | ||
| eval searcher_input_on_visibility_toggle ((expr) model.input_changed(expr)); |
There was a problem hiding this comment.
Why do we need to reset searcher input in controllers after a reload?
There was a problem hiding this comment.
Yup, it looks strange and performance-hurting. Good catch @farmaazon!
There was a problem hiding this comment.
After reloading the component list we need to update the filtering. Otherwise, all components will be shown after a toggle, irrespective of them matching the searcher input pattern.
I've refactored this to only call the update_filtering methods and not set a new searcher input, as indeed the searcher input does not change.
app/gui/src/presenter/searcher.rs
Outdated
| searcher_input_on_visibility_toggle <- | ||
| model.view.searcher_input_changed.sample(&reloading_action_list_done); | ||
| eval searcher_input_on_visibility_toggle ((expr) model.input_changed(expr)); |
There was a problem hiding this comment.
Why do we need to reset searcher input in controllers after a reload?
app/gui/src/presenter/searcher.rs
Outdated
| searcher_input_on_visibility_toggle <- | ||
| model.view.searcher_input_changed.sample(&reloading_action_list_done); | ||
| eval searcher_input_on_visibility_toggle ((expr) model.input_changed(expr)); |
There was a problem hiding this comment.
Yup, it looks strange and performance-hurting. Good catch @farmaazon!
…isibility-184215360
…15360' of github.com:enso-org/enso into wip/galin-enso/toggle-cb-private-method-visibility-184215360
There was a problem hiding this comment.
QA tried to break this PR, but hasn't succeeded.
Only one UX note: when turning on the debug mode, we see the popup confirming it. We could consider using it for "show private entries" mode as well.
However, I suspect this pop-up will be refactored as part of #5201 so let's do not do this right now.
…isibility-184215360
…isibility-184215360
mergify
bot
deleted the
wip/galin-enso/toggle-cb-private-method-visibility-184215360
branch
Pull Request Description
Closes #4962
This PR adds the
cmd+alt+pshortcut to toggle the visibility of components with a "PRIVATE" tag in the component browser. The default is to have these private components hidden.unknown_2023.02.15-18.26.mp4
Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.