Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GraalVM to 22.3.1 #5602

Merged
merged 19 commits into from
Feb 14, 2023
Merged

Update GraalVM to 22.3.1 #5602

merged 19 commits into from
Feb 14, 2023

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Feb 9, 2023

Pull Request Description

Updates the engine to GraalVM 22.3.1 version, which contains fixes for:

  • Chrome inspector issues - 38eb3b5

Important Notes

  • Update to GraalVM 22.3.1
  • Remove host object wrapping workaround

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@Akirathan Akirathan linked an issue Feb 9, 2023 that may be closed by this pull request
@Akirathan Akirathan added -compiler CI: Clean build required CI runners will be cleaned before and after this PR is built. labels Feb 9, 2023
@JaroslavTulach
Copy link
Member

...added clean build...

Yup, that needs clean build.

@Akirathan Akirathan force-pushed the wip/akirathan/update-graal-5086 branch from c437909 to f9729d8 Compare February 10, 2023 09:38
@Akirathan Akirathan removed the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Feb 10, 2023
@Akirathan Akirathan force-pushed the wip/akirathan/update-graal-5086 branch from a918330 to 0b2ba68 Compare February 10, 2023 14:32
@Akirathan Akirathan marked this pull request as ready for review February 10, 2023 14:32
@Akirathan Akirathan self-assigned this Feb 10, 2023
@Akirathan Akirathan force-pushed the wip/akirathan/update-graal-5086 branch from 0b2ba68 to b97b372 Compare February 10, 2023 15:23
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good to see this workaround gone! 🎉

I assume you have tested that the new build works as expected in Chrome Inspector? Because I think we didn't have unit tests for it, so definitely would be good to verify if the fix was enough.

CHANGELOG.md Outdated Show resolved Hide resolved
@Akirathan
Copy link
Member Author

Akirathan commented Feb 10, 2023

I assume you have tested that the new build works as expected in Chrome Inspector? Because I think we didn't have unit tests for it, so definitely would be good to verify if the fix was enough.

I have verified that on debugging Scatter_Plot_Spec.enso. Also, we have some unit tests for that in https://github.com/enso-org/enso/blob/develop/engine/runtime/src/test/java/org/enso/interpreter/test/DebuggingEnsoTest.java that even contained the check for the workaround that I had to remove in this PR.

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

@Akirathan Akirathan added the CI: Ready to merge This PR is eligible for automatic merge label Feb 10, 2023
@radeusgd
Copy link
Member

I assume you have tested that the new build works as expected in Chrome Inspector? Because I think we didn't have unit tests for it, so definitely would be good to verify if the fix was enough.

I have verified that on debugging Scatter_Plot_Spec.enso. Also, we have some unit tests for that in develop/engine/runtime/src/test/java/org/enso/interpreter/test/DebuggingEnsoTest.java that even contained the check for the workaround that I had to remove in this PR.

GitHub**enso/DebuggingEnsoTest.java at develop · enso-org/enso**Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

Ah sorry! I missed that. Looks amazing then 😁

Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

200 hacky lines deleted! Nice.

Copy link
Contributor

@4e6 4e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mergify mergify bot merged commit 3e8467c into develop Feb 14, 2023
@mergify mergify bot deleted the wip/akirathan/update-graal-5086 branch February 14, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-compiler CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GraalVM to 22.3.1 to fix chrome inspector
6 participants