-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sbt runEngineDistribution ...args... to build and execute the engine #5609
Conversation
CCing Michal, as this enhancement shall work fine with
as well. E.g. it is not just another helper script, but a step towards ultimate integration with CI tools. Overall I tend to start believing that download related task shall be solved by |
Nice - could we have this on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not suite my personal workflow, as I use custom key bindings for engine building in IntelliJ, but is very helpful nonetheless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest moving this logic in the DistributionPackage
module.
Done in 7a3697d |
Adding this execution to a single task isn't hard - see the current changes in Adding this to all the various tasks for building libraries requires some |
``` | ||
|
||
Then one can execute the launcher: | ||
One can use the `runEngineDistribution` command or execute the launcher: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this was already there, but technically this executable is the runner. The launcher is a separate project. Can we rename it to reduce possible confusion?
|
||
```bash | ||
enso$ ./built-distribution/enso-engine-0.0.0-dev-linux-amd64/enso-0.0.0-dev/bin/enso --dump-graphs --run yourprogram.enso | ||
enso$ sbt runEngineDistribution --dump-graphs --run yourprogram.enso |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very cool 🎉
…neDistribution' into wip/jtulach/RunEngineDistribution
Pull Request Description
Automating the assembly of the engine and its execution into a single task. If you are modifying standard libraries, engine sources or Enso tests, you can launch
sbt
and then just:the runEngineDistribution
sbt
input task makes sure all your sources are properly compiled and only then executes your enso source. Everything ready at a single press of Enter.Important Notes
To debug in chrome dev tools, just add
--inspect
:everything gets build and one can just attach the Enso debugger.
Checklist
Please include the following checklist in your PR:
Scala,
style guides.