Fix separate compilation for ConstantsGen #5630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
added
the
CI: No changelog needed
4e6
approved these changes
Feb 10, 2023
hubertp
added
CI: Ready to merge
A combination of commands triggered separate compilation that only recompiled part of builtins. A mechanism that workaround annotation processor's problems with separate compilation was updated to include changes from #4111. This was pretty tough to find given the rather unusual circumstances in CI.
hubertp
force-pushed
the
wip/hubert/processor-separate-compilation
branch
from
d193be3
to
56ef85b
Compare
| ); | ||
|
|
||
| out.println(); | ||
| out.println("}"); | ||
| } | ||
| } | ||
|
|
||
| public void generateEntry(String name, String value, PrintWriter out) { |
There was a problem hiding this comment.
What is a "copy based programming" error fixed by introducing generateEntry method and using it consistently?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
A combination of commands triggered separate compilation that only recompiled part of builtins. A mechanism that workaround annotation processor's problems with separate compilation was updated to include changes from #4111. This was pretty tough to find given the rather unusual circumstances in CI.
Important Notes
This eliminates the random failures in CI related to separate compilation.
To reproduce a specific set of steps has to be executed:
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.