Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File.parent can return Nothing #5699

Merged
merged 4 commits into from
Feb 20, 2023
Merged

File.parent can return Nothing #5699

merged 4 commits into from
Feb 20, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Feb 20, 2023 •
edited
Loading

Pull Request Description

File.parent can be Nothing

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Java,
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach self-assigned this Feb 20, 2023
@JaroslavTulach JaroslavTulach mentioned this pull request Feb 20, 2023
Closed
@JaroslavTulach JaroslavTulach linked an issue Feb 20, 2023 that may be closed by this pull request
EnsoFile throws unexpected NPE #5270
Closed
radeusgd
radeusgd approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad that this edge case has been caught. The code and tests look good.

I'm wondering if we could do even better, but this PR is already an improvement.

test/Tests/src/System/File_Spec.enso Show resolved Hide resolved
@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Feb 20, 2023
@JaroslavTulach JaroslavTulach mentioned this pull request Feb 20, 2023
Open
2 tasks
@mergify mergify bot merged commit 97bcd87 into develop Feb 20, 2023
@mergify mergify bot deleted the wip/jtulach/EnsoFileNPE_5270 branch February 20, 2023 19:13
@enso-bot enso-bot bot mentioned this pull request Feb 21, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@radeusgd radeusgd radeusgd approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EnsoFile throws unexpected NPE
4 participants
@JaroslavTulach @hubertp @radeusgd @jdunkerley