support custom widget entry labels #5705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frizi
force-pushed
the
wip/frizi/custom-dropdown-labels
branch
from
ba22b7f
to
e1f01a8
Compare
Frizi
commented
Feb 20, 2023
Frizi
requested review from
MichaelMauderer,
wdanilo,
farmaazon,
mwu-tow and
kazcw
as code owners
This was
linked to
issues
Feb 27, 2023
|
What is the status of this? CC @sylwiabr |
|
@Frizi ? |
Frizi
force-pushed
the
wip/frizi/custom-dropdown-labels
branch
3 times, most recently
from
26221a9
to
7a10ac9
Compare
|
Since last change request
|
Frizi
force-pushed
the
wip/frizi/custom-dropdown-labels
branch
from
7a10ac9
to
1f1681b
Compare
2 tasks
wdanilo
approved these changes
Mar 15, 2023
CHANGELOG.md
Outdated
| @@ -111,6 +111,7 @@ | |||
| - [Named arguments syntax is now recognized in IDE][5774]. Connections to | |||
| function arguments will now use named argument syntax instead of inserting | |||
| wildcards on all preceding arguments. | |||
| - [Added more user-friendly labels to dropdown widgets.][5705] | |||
There was a problem hiding this comment.
Please make it more wordy. Explanations in changeling should be understandable by no-code users. "more user-friendly" does not tell much .
Comment on lines
+137
to
+163
| /// Delay and deduplicate the incoming events. Once an event is received, it will be emitted | ||
| /// after the current program execution finishes, but before returning to the event loop. If | ||
| /// multiple events are received within the same microtask, only the last one will be emitted. | ||
| /// | ||
| /// Use [`Network::batch`] if you want to collect all emitted values within a microtask. | ||
| /// | ||
| /// ```text | ||
| /// Input: ───────1──2─3─────────── | ||
| /// Microtasks: ── ▶──── ▶──── ▶──── ▶── | ||
| /// Output: ─────────1─────3──────── | ||
| /// ``` | ||
| /// | ||
| /// This node is useful when dealing with a diamond-shaped network, where a single source event | ||
| /// is flowing into multiple subgraphs, and those subgraphs eventually merge into a single node. | ||
| /// That final node would ordinarily receive multiple events for the same source event, once per | ||
| /// execution of each subgraph. It is usually a waste of resources to process those intermediate | ||
| /// events, and it can even lead to logical errors, as those events may contain partially | ||
| /// outdated data. This node can be used to deduplicate the events and only process the most | ||
| /// up-to-date one once all subgraphs have finished their execution. | ||
| /// | ||
| /// Example network with a diamond-shaped subgraph: | ||
| /// ```text | ||
| /// clickPosition | ||
| /// / \ | ||
| /// / \ | ||
| /// posX absPosY | ||
| /// \ / |
Frizi
force-pushed
the
wip/frizi/custom-dropdown-labels
branch
from
3b1e2e1
to
829eeb3
Compare
Frizi
force-pushed
the
wip/frizi/custom-dropdown-labels
branch
from
829eeb3
to
85af9d8
Compare
Oh, that's nice. I think we can use it to fix CB in #5770 instead of creating a 0-ms timer. @farmaazon jfyi |
|
@Frizi is it ready for QA? |
|
@sylwiabr yes, it is waiting for QA now. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Implements #5640 and #5650
It made sense for me to implement those two together, as I wanted to make sure that the necessary widget API changes will support custom entry values for both dynamic and static data.
Important Notes
During implementation I had multiple data update order issues caused by FRP network forming a diamond shape. Two inputs that are often updated together were combined with
allcombinator, and that was further fed into the dropdown. This caused two updates to propagate through the whole network, and one of them was immediately outdated. To fix this and similar future scenarios, I've added annext_tickFRP node. It buffers the incoming events until the next browser microtask, preserving only the last received event. Currently if it is called inside arequestAnimationFramecallback, the effects of that processing will only be rendered in the next frame. Later this can be mitigated by delaying the rendering logic until the microtask queue is empty.Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.