Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex.Compile using Truffle Regex, update find, match and match_all #5785

Merged
merged 70 commits into from
Mar 10, 2023
Merged

Regex.Compile using Truffle Regex, update find, match and match_all #5785

merged 70 commits into from
Mar 10, 2023

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Mar 1, 2023 •
edited
Loading

Pull Request Description

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@CLAassistant
Copy link

CLAassistant commented Mar 1, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Mar 8, 2023
@GregoryTravis GregoryTravis added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Mar 9, 2023
@jdunkerley jdunkerley removed the CI: Ready to merge This PR is eligible for automatic merge label Mar 10, 2023
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Mar 10, 2023
@jdunkerley jdunkerley removed the CI: Ready to merge This PR is eligible for automatic merge label Mar 10, 2023
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Mar 10, 2023
@mergify mergify bot merged commit 7887fb8 into develop Mar 10, 2023
@mergify mergify bot deleted the wip/gmt/compile-regexp branch March 10, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@GregoryTravis GregoryTravis GregoryTravis left review comments

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@hubertp hubertp hubertp approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

Assignees
No one assigned
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regex.compile shall compile just once. Create new Regex types and use for match, find and find_all.
6 participants
@jdunkerley @CLAassistant @hubertp @radeusgd @GregoryTravis @JaroslavTulach