Cognito auth 2/7 - add authorization app #5798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloBuchu
changed the title
…-auth-authorization-app
wip/pb/cognito-auth-authorization-app
…-auth-authorization-app
PabloBuchu
added
CI: No changelog needed
wdanilo
approved these changes
Mar 14, 2023
| @@ -111,6 +111,7 @@ | |||
| - [Named arguments syntax is now recognized in IDE][5774]. Connections to | |||
| function arguments will now use named argument syntax instead of inserting | |||
| wildcards on all preceding arguments. | |||
| - [Added boilerplate React app for authorization via Cognito+AWS Amplify][5798]. | |||
There was a problem hiding this comment.
Please make it a little bit more wordy and easier to read. The Changeling should be understandable by no-code users :)
| @@ -36,6 +37,7 @@ | |||
| "electron-builder": "^22.14.13", | |||
| "electron-notarize": "1.2.2", | |||
| "enso-copy-plugin": "^1.0.0", | |||
| "enso-studio-common": "^1.0.0", | |||
There was a problem hiding this comment.
We do not have "Enso Studio" anymore. It is super old name and instead of that we are using "Enso" now. In case "Enso" would not be sufficient, we can use "Enso IDE", but "Enso" would be better and more consistent.
somebody1234
force-pushed
the
wip/pb/cognito-auth-authorization-app
branch
from
e196722
to
109e51d
Compare
|
i've taken the liberty to:
|
|
afaict the only issue left to be addressed is the one about the changelog message |
…so-org/enso into wip/pb/cognito-auth-authorization-app
mwu-tow
approved these changes
Mar 15, 2023
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
2nd PR for IDE/Cloud authorization with cognito. This PR introduces boilerplate react app + some amplify code to fetch the access token + username of the currently logged in user, if they are already authenticated.
Registration + Login + Set Username + Forgot Password flows are to be added in next PRs to keep the changes reviewable.
Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.