Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross_tab column naming edge cases, add fill_empty #5863

Merged
merged 14 commits into from
Mar 11, 2023

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Mar 8, 2023

Pull Request Description

Closes #5151 and adds some additional tests for cross_tab that verify duplicated and invalid names.

I decided that for empty or Nothing names, instead of replacing them with Column and implicitly losing connection with the value that was in the column, we should just error on such values.

To make handling of these easier, fill_empty was added allowing to easily replace the empty values with something else.

Also, {is,fill}_missing was renamed to {is,fill}_nothing to align with Filter_Condition.Is_Nothing.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using ./run ide build.

@radeusgd radeusgd self-assigned this Mar 8, 2023
CHANGELOG.md Show resolved Hide resolved
@radeusgd radeusgd force-pushed the wip/radeusgd/common-polyglot-core-utils branch from 8e077e2 to db6b824 Compare March 9, 2023 10:12
@radeusgd radeusgd force-pushed the wip/radeusgd/common-polyglot-core-utils branch from db6b824 to 89bf974 Compare March 9, 2023 10:14
@radeusgd radeusgd force-pushed the wip/radeusgd/5151-cross-tab-unique-naming branch from c43ec1e to e40c39e Compare March 9, 2023 10:19
@radeusgd radeusgd force-pushed the wip/radeusgd/common-polyglot-core-utils branch from 89bf974 to dbbf4ef Compare March 10, 2023 23:11
@radeusgd radeusgd force-pushed the wip/radeusgd/5151-cross-tab-unique-naming branch from e40c39e to b854770 Compare March 10, 2023 23:29
Base automatically changed from wip/radeusgd/common-polyglot-core-utils to develop March 11, 2023 09:27
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Mar 11, 2023
@mergify mergify bot merged commit 952beba into develop Mar 11, 2023
@mergify mergify bot deleted the wip/radeusgd/5151-cross-tab-unique-naming branch March 11, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Unique Name Strategy for Cross Tab
3 participants