Don't log installed engines and runtimes in prod #5900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
force-pushed
the
wip/hubert/5749-graalvm-updater
branch
from
010980f
to
4a121cf
Compare
radeusgd
approved these changes
Mar 13, 2023
| @@ -339,7 +339,7 @@ class RuntimeVersionManager( | |||
| result match { | |||
| case (path, Failure(exception)) => | |||
| logger.warn( | |||
| "{} at [{}] has been skipped due to the following error: {}", | |||
There was a problem hiding this comment.
it will actually skip it because of the way the last argument is treated if it is an exception. So it would always be empty from what I saw. This way it should included the stacktrace.
There was a problem hiding this comment.
The action will check and install all necessary components of GraalVM for every mentioned version. While not harmful, it adds up to startup time. Additionally added an option in language server startup to skip installation of GraalVM components. The latter is already performed by project-manager when opening the project and it is unnecessary to do it twice. Due to LS' architecture this configuration has to be passed around via multiple configs. Finally, skipped the attempt to install Python component on Windows - this is not supported by GraalVM atm. Closes #5749.
hubertp
force-pushed
the
wip/hubert/5749-graalvm-updater
branch
from
c2739ce
to
accd63a
Compare
JaroslavTulach
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The
logAvailableComponentsForDebuggingwill check and install all necessary components of GraalVM for every mentioned version. While not harmful, it adds up to startup time.Additionally added an option in language server startup to skip installation of GraalVM components. The latter is already performed by project-manager when opening the project and it is unnecessary to do it twice. Due to LS' architecture this configuration has to be passed around via multiple configs.
Finally, skipped the attempt to install Python component on Windows - this is not supported by GraalVM atm.
Closes #5749.
Important Notes
The impact of this problem could be really felt the more versions of Enso and GraalVM one had since it would go through all of them.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.