Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort handles incomparable values #5998
sort handles incomparable values #5998
Changes from 46 commits
299c9d4
b8a9c9e
38b6b8a
3f66d8a
e57c4ae
603ab95
95c0878
0df66b1
b5692b8
75d3178
f8deb71
82ac86b
e695e1f
219aa4a
38057d7
8bd3e00
1360be6
4fbdc0d
8dfb873
1528446
80c69d0
e0881f4
19d2d6f
9278734
af9dfa3
7f2af25
ed97b04
c726753
92a10a8
8f78728
e2075d9
6983769
85be93d
a2bfc8b
310f1df
fee458a
7f933dd
ddcdacb
08f0e31
5bc344e
a8091d1
d4b487e
b39ea29
2a41993
9e04935
cc1f527
715fe94
8268e02
254d579
8174ca6
672afb0
6b8f147
d9a12a0
8718c99
1f23d83
ab2f95a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(.start)
is parsed toUnresolvedSymbol<start>
, and I found no easy way how to call that. Whereas(_.start)
is parsed intoFunction
. I created issue #6726 to track that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#6276 *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the convention is to use
##
for the multiline comments. Unless there was some issue with it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw. I think this raises a good point that we may want to have a way to import conversion methods without necessarily importing
all
. What do you think? Shall we start a discussion?I guess one way to do so should be to do
import project.Data.Ordering
instead. I'm pretty sure the not-from
imports do import the extension methods within.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But maybe a more explicit way for this would be good too. Just a random thought, low priority. Definitely independent of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. I guess it depends on whether the current behavior is the expected one, i.e., if I import a type with
import Standard.Base.Data.Ordering.Comparable.Comparable
, then all its extension methods from that module are imported as well, but not any conversion methods - neither those withComparable
as target, neither those withComparable
as source. Is this intuitive/expected/bug?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I don't know.
My intuition would be that if I import a type, probably it's extension methods are imported too... But probably only its and not others.
I'd appreciate a way to import only extension methods from a file, but that's just my subjective view. Also definitely not something of high priority, as we are doing fine with current state of the import system, I think.