Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Regular Expression split and update Text.split to the new API #6116

Merged
merged 188 commits into from
Mar 30, 2023

Conversation

GregoryTravis
Copy link
Contributor

Pull Request Description

Re-implement split on top of Truffle regex.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@GregoryTravis GregoryTravis marked this pull request as ready for review March 28, 2023 14:05
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Some comments need aligning, and I suggested a few more tests to add.

I'm wondering if a limit argument wouldn't be better than only_first, as it allows for more flexibility. I think it could be useful, and shouldn't make the implementation more complex. But that's a discussion closer to design, so I'm fine with dealing with this at a different time.

@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Mar 30, 2023
@mergify mergify bot merged commit c8f5a91 into develop Mar 30, 2023
@mergify mergify bot deleted the wip/gmt/5123-split branch March 30, 2023 13:05
@jdunkerley jdunkerley linked an issue Mar 30, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Text.split and add Text.tokenize.
4 participants