-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Regular Expression split and update Text.split to the new API #6116
Conversation
Co-authored-by: Radosław Waśko <radoslaw.wasko@enso.org>
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Extensions.enso
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Some comments need aligning, and I suggested a few more tests to add.
I'm wondering if a limit
argument wouldn't be better than only_first
, as it allows for more flexibility. I think it could be useful, and shouldn't make the implementation more complex. But that's a discussion closer to design, so I'm fine with dealing with this at a different time.
Pull Request Description
Re-implement split on top of Truffle regex.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.