Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disregard visualisation for selection of nodes. #6487

Merged
merged 5 commits into from
May 4, 2023

Conversation

MichaelMauderer
Copy link
Contributor

@MichaelMauderer MichaelMauderer commented May 1, 2023

Pull Request Description

Fixes #5628. Uses the bounding box of nodes without the visualization for determining area selection.

Peek.2023-05-01.13-24.mp4

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@MichaelMauderer MichaelMauderer self-assigned this May 1, 2023
@MichaelMauderer MichaelMauderer added CI: No changelog needed Do not require a changelog entry for this PR. and removed CI: No changelog needed Do not require a changelog entry for this PR. labels May 1, 2023
@Procrat
Copy link
Contributor

Procrat commented May 4, 2023

QA: Looks good to me!

@MichaelMauderer MichaelMauderer added the CI: Ready to merge This PR is eligible for automatic merge label May 4, 2023
@wdanilo wdanilo merged commit 1817da7 into develop May 4, 2023
@wdanilo wdanilo deleted the wip/MichaelMauderer/Node_selection_issues#5628 branch May 4, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node selection issues
3 participants