Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node selection issues #5628

Closed
2 tasks
sylwiabr opened this issue Feb 10, 2023 · 3 comments · Fixed by #6487
Closed
2 tasks

Node selection issues #5628

sylwiabr opened this issue Feb 10, 2023 · 3 comments · Fixed by #6487
Assignees
Labels
--bug Type: bug d-intermediate Difficulty: some prior knowledge required p-low Low priority

Comments

@sylwiabr
Copy link
Member

Discord username

No response

What type of issue is this?

Permanent – Ocurring repeatably

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

when selecting nodes with selection area it behaves inconsistent (you need to be closer to the node if you are selecting it from right side then from the left side) and sometimes you are selecting nodes that are far away accidentally (see screenshot)

Expected behaviour

I select node if rectangle is at least touching the node

How we can reproduce it?

No response

Screenshots or screencasts

Screenshot 2023-02-10 at 15 49 25

Screen.Recording.2023-02-10.at.17.39.11.mov

Enso Version

2023.1.1-nightly.2023.2.9

Browser or standalone distribution

Standalone distribution

Browser Version or standalone distribution

standalone

Operating System

MacOS

Operating System Version

No response

Hardware you are using

No response

@farmaazon
Copy link
Contributor

It may be caused by the extended bounding box when visualization is visible.

@vitvakatu
Copy link
Contributor

Yep, it is caused by the bounding box of the visualization. I guess we should use different bounding boxes for selecting nodes and for calculating their layout on the scene.

@vitvakatu vitvakatu moved this from ❓New to 📤 Backlog in Issues Board Feb 13, 2023
@vitvakatu vitvakatu added d-intermediate Difficulty: some prior knowledge required p-low Low priority and removed triage labels Feb 13, 2023
@sylwiabr sylwiabr changed the title Selection issues Node selection issues Feb 21, 2023
@farmaazon farmaazon assigned vitvakatu and unassigned farmaazon Feb 24, 2023
@MichaelMauderer MichaelMauderer moved this from 📤 Backlog to 👁️ Code review in Issues Board May 1, 2023
@enso-bot
Copy link

enso-bot bot commented May 1, 2023

Michael Mauderer reports a new STANDUP for today (2023-05-01):

Progress: Opened PR for #6371. Investigated how to fix the area selection capturing nodes when touching their visualizations and implemented the fix. It should be finished by 2023-05-01.

Next Day: Next day I will be working on the #5088 task. Implement spinner for visualization waiting on data.

@MichaelMauderer MichaelMauderer moved this from 👁️ Code review to 🌟 Q/A review in Issues Board May 4, 2023
@github-project-automation github-project-automation bot moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board May 4, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug d-intermediate Difficulty: some prior knowledge required p-low Low priority
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants