Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine benchmarks download tool is able to plot multiple branches #7257

Merged
merged 10 commits into from
Jul 13, 2023

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Jul 11, 2023

Pull Request Description

Engine benchmark downloader tool bench_download.py can now plot multiple branches in the same charts. The tooltips on the charts, displayed when you hover over some data point, are now broken for some branches. I have no idea why, it might be a technical limitation of the Google charts library. Nevertheless, I have also extended the selection info section, that is displayed under every chart, where one can see all the important information, once you click on some data point.

Options added:

  • --branches specifies list of branches for which all the benchmark data points will be in the plots. The default is develop only.
  • --labels that can limit the number of generated charts.

This PR also deprecates the --compare option. There is no reason to keep that option around since we can now plot all the branches in the same charts.

An example for plotting benchmarks for PR #7009 with

python bench_download.py -v --since 2023-07-01 --until 2023-07-11 --branches develop wip/jtulach/ArgumentConversion

is:
image

Important Notes

  • Deprecate --compare option
  • Add --labels option
  • Add --branches option

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@Akirathan Akirathan self-assigned this Jul 11, 2023
@Akirathan Akirathan added the -tooling Category: tooling label Jul 11, 2023
@Akirathan Akirathan marked this pull request as ready for review July 11, 2023 13:41
@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 11, 2023
@Akirathan Akirathan added CI: Ready to merge This PR is eligible for automatic merge CI: Keep up to date Automatically update this PR to the latest develop. labels Jul 13, 2023
@Akirathan Akirathan removed the CI: Keep up to date Automatically update this PR to the latest develop. label Jul 13, 2023
@mergify mergify bot merged commit 2b1c7c6 into develop Jul 13, 2023
26 of 28 checks passed
@mergify mergify bot deleted the wip/akirathan/bench-tool-compare-branches branch July 13, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-tooling Category: tooling CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants