Engine benchmarks download tool is able to plot multiple branches #7257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Engine benchmark downloader tool bench_download.py can now plot multiple branches in the same charts. The tooltips on the charts, displayed when you hover over some data point, are now broken for some branches. I have no idea why, it might be a technical limitation of the Google charts library. Nevertheless, I have also extended the selection info section, that is displayed under every chart, where one can see all the important information, once you click on some data point.
Options added:
--branches
specifies list of branches for which all the benchmark data points will be in the plots. The default isdevelop
only.--labels
that can limit the number of generated charts.This PR also deprecates the
--compare
option. There is no reason to keep that option around since we can now plot all the branches in the same charts.An example for plotting benchmarks for PR #7009 with
is:
![image](https://private-user-images.githubusercontent.com/14013887/252651825-62010850-79d2-4c6c-92bc-9627bb4c6a0b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA2NDUwNjEsIm5iZiI6MTcyMDY0NDc2MSwicGF0aCI6Ii8xNDAxMzg4Ny8yNTI2NTE4MjUtNjIwMTA4NTAtNzlkMi00YzZjLTkyYmMtOTYyN2JiNGM2YTBiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEwVDIwNTI0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU5YjE5MmE2MmJkZWQ0YTFmZGZjMzQ1YjM2ZGNjNTQxYjc5M2U3ZTYxODI5Y2RjNDk0ZDQ4ODY3ZWZkNTdiZDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.OU2mFmckuunyd05If3c1UMOz-DGsDFGqC5vI0IE-QPQ)
Important Notes
--compare
option--labels
option--branches
optionChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.