No need to depend on EnsoContext when working with PackageRepository #7276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
commented
Jul 13, 2023
| * @param file the module to find the package of | ||
| * @return {@code module}'s package, if exists | ||
| */ | ||
| public static Optional<Package<TruffleFile>> getPackageOf( |
There was a problem hiding this comment.
These two methods don't need any EnsoContext. They operate only on PackageRepository - moving them away as static ones into PackageRepositoryUtils class. Why a new class? Because the code was written in Java and PackageRepository is in Scala. I certainly don't want to rewrite existing Java code into Scala.
4e6
approved these changes
Jul 13, 2023
JaroslavTulach
added
the
CI: Ready to merge
|
Probably random failure in RuntimeServerTest... live vs. design... restarted. |
I have seen this failure in the last few weeks as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
On a quest to avoid dependencies on
EnsoContextfromCompiler. Step one. The ultimate goal is to moveCompilerand all itsIRPassesinto a dedicatedruntime/compilermodule that could be used from #7054.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala and Java,