Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node pending status does not show/propagate correctly when recalculating #7021

Closed
jdunkerley opened this issue Jun 13, 2023 · 9 comments
Closed

Comments

@jdunkerley
Copy link
Member

jdunkerley commented Jun 13, 2023

Using the current Orders example.

When you open the project, the nodes will load in a pending state and then propagate updates correctly.
When you change a dropdown value, the IDE appears to freeze while it recalculates
The pending status does appear on connections but the flow of updates appears to stutter.
Appears particularly bad with errors in the graph.

2023-06-14_10-23-31.mp4

Using develop build as of 14th June.

@jdunkerley jdunkerley self-assigned this Jun 13, 2023
@jdunkerley jdunkerley added -libs Libraries: New libraries to be implemented -language-server and removed -libs Libraries: New libraries to be implemented labels Jun 13, 2023
@jdunkerley jdunkerley changed the title Create a progress bug Node pending status does not show/propogate when recalculating Jun 14, 2023
@jdunkerley jdunkerley removed their assignment Jun 14, 2023
@jdunkerley jdunkerley changed the title Node pending status does not show/propogate when recalculating Node pending status does not show/propagate correctly when recalculating Jun 14, 2023
@JaroslavTulach
Copy link
Member

IDE appears to freeze while it recalculates

We need to find out whether freeze is on the engine or the IDE side. If it is on the engine side, we need to capture profiling data. It is a shame we don't have anything like

and the best way to report a bug is to tape it without any additional useful information. Forcing others to replay the video manually. What a waste of time.

@jdunkerley
Copy link
Member Author

#7183 (comment)

The second video in here doesn't show the progress.

@JaroslavTulach
Copy link
Member

I will investigate more, but please note following comment: #7020 (comment) - the way IDE "highlights" pending nodes is very invisible: only by gray underlined bottom.

@enso-bot
Copy link

enso-bot bot commented Jul 12, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-07-11):

Progress: - Crossing the boundary experiment: #5067 (comment)

  • planning meeting
  • triaging It should be finished by 2023-07-15.

Next Day: Investigate node pending status

@JaroslavTulach
Copy link
Member

Using the current Orders example.

I assume the project can be found at project-templates repository.

@JaroslavTulach
Copy link
Member

First of all, I don't see any hiccups. After a change of a parameter of the read method, the IDE recomputes swiftly. Second...

... note following comment: #7020 (comment) - the way IDE "highlights" pending nodes is very invisible: only by gray underlined bottom.

when I modify the Orders/src/Main.enso to delay computation of some nodes by 5s and I change the parameter of read, then

gray bottom

then the bottom of the last node is grayed out properly. E.g. the IDE has enough information about pending nodes and underlines such nodes properly. Closing.

@farmaazon
Copy link
Contributor

farmaazon commented Jul 12, 2023

The new look of pending nodes is a part of the new design, they will be wholly faded a bit:

image

@enso-bot
Copy link

enso-bot bot commented Jul 13, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-07-12):

Progress: - investigating Node pending status

Next Day: Bugfixes & performance

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

@enso-bot
Copy link

enso-bot bot commented Jul 14, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-07-13):

Progress: - merged less dependencies of a compiler: #7276

Next Day: Bugfixes & performance

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants