Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yield UnclosedTextLiteral syntax errors #7340

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Yield UnclosedTextLiteral syntax errors #7340

merged 3 commits into from
Jul 21, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Jul 20, 2023 •
edited
Loading

Pull Request Description

Fixes #7279 by detecting missing getClose() and yielding an UnclosedTextLiteral.

Important Notes

Special care must be taken for text blocks. They have null getClose().

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 20, 2023
@JaroslavTulach JaroslavTulach self-assigned this Jul 20, 2023
@JaroslavTulach JaroslavTulach mentioned this pull request Jul 20, 2023
Closed
@JaroslavTulach JaroslavTulach added CI: Ready to merge This PR is eligible for automatic merge CI: Keep up to date Automatically update this PR to the latest develop. labels Jul 21, 2023
@JaroslavTulach JaroslavTulach added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Jul 21, 2023
@mergify mergify bot merged commit 76457b0 into develop Jul 21, 2023
23 of 25 checks passed
@mergify mergify bot deleted the wip/jtulach/UnclosedLiteral_7279 branch July 21, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 4e6 approved these changes

@radeusgd radeusgd radeusgd approved these changes

@Akirathan Akirathan Akirathan approved these changes

@kazcw kazcw Awaiting requested review from kazcw

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Keep up to date Automatically update this PR to the latest develop. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclosed text literal issues no syntax error
4 participants
@JaroslavTulach @4e6 @radeusgd @Akirathan