Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplifying builtins type system support #7344

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Simplifying builtins type system support #7344

merged 3 commits into from
Jul 24, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Jul 20, 2023 •
edited
Loading

Pull Request Description

Inspired by #6912. Explores various simplifications of the "type system" used by Enso builtins.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 20, 2023
@JaroslavTulach JaroslavTulach self-assigned this Jul 20, 2023
@JaroslavTulach JaroslavTulach marked this pull request as draft July 20, 2023 06:36
@enso-bot enso-bot bot mentioned this pull request Jul 21, 2023
Closed
@JaroslavTulach JaroslavTulach added the CI: Keep up to date Automatically update this PR to the latest develop. label Jul 21, 2023
@JaroslavTulach JaroslavTulach removed the CI: Keep up to date Automatically update this PR to the latest develop. label Jul 21, 2023
@JaroslavTulach JaroslavTulach marked this pull request as ready for review July 24, 2023 11:20
4e6
4e6 approved these changes Jul 24, 2023
View reviewed changes
engine/runtime/src/main/java/org/enso/interpreter/runtime/type/Types.java
* @param value an object of interest.
* @return the string representation of object's type.
*/
public static String getName(Object value) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JaroslavTulach JaroslavTulach merged commit b9a6e35 into develop Jul 24, 2023
24 of 26 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/BuiltinsAndTypes_6912 branch July 24, 2023 11:27
@JaroslavTulach JaroslavTulach mentioned this pull request Jul 24, 2023
Closed
Frizi pushed a commit that referenced this pull request Jul 25, 2023
@JaroslavTulach @Frizi
Simplifying builtins type system support (#7344)
9eadcd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 4e6 approved these changes

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JaroslavTulach @4e6