Avoid using a (warnings) Library on this #7525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
This was referenced Aug 9, 2023
Merged
hubertp
approved these changes
Aug 9, 2023
radeusgd
reviewed
Aug 9, 2023
engine/runtime/src/main/java/org/enso/interpreter/runtime/data/Vector.java
Show resolved
Hide resolved
JaroslavTulach
added
the
CI: Keep up to date
JaroslavTulach
added
the
CI: Ready to merge
radeusgd
approved these changes
Aug 10, 2023
Akirathan
approved these changes
Aug 10, 2023
JaroslavTulach
removed
the
CI: Keep up to date
JaroslavTulach
added a commit
that referenced
this pull request
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
While investigating behavior of
in IGV I realized there is a deep chain of nodes when reading an element of
Vectorrelated to work with warnings. There is an invocation ofWarningsLibraryonthis- that's probably unnecessary as we know how it is going to resolve. This PR skips such one level of indirection by directly delegating tothis.storage.However I haven't seen any effect of this change on peak performance. The library overhead seems to disappear. Anyway I wanted to bring this finding to your attention and perform independent measurement on our CI server.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,