Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Enso-specific assert #7883

Merged
merged 26 commits into from
Sep 29, 2023
Merged

Implement Enso-specific assert #7883

merged 26 commits into from
Sep 29, 2023

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Sep 25, 2023

Closes #5973

Pull Request Description

Implement Enso-specific assert - Runtime.assert that works like asserts in any other runtime.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@Akirathan Akirathan self-assigned this Sep 25, 2023
@Akirathan Akirathan linked an issue Sep 25, 2023 that may be closed by this pull request
@radeusgd
Copy link
Member

Can we ensure that we enable the ENSO_ENABLE_ASSERTIONS env var on the CI?

@Akirathan
Copy link
Member Author

Can we ensure that we enable the ENSO_ENABLE_ASSERTIONS env var on the CI?

Sure, I added it to the task list so that I don't forget about it.

Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions:

  • please justify use of Assertion for a non-dynamic state.
  • do we really need new Enso CLI parameter?

Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace InteropLibrary with EqualsNode or co. Otherwise OK.

@@ -1334,6 +1335,7 @@ lazy val runtime = (project in file("engine/runtime"))
"org.typelevel" %% "cats-core" % catsVersion,
"junit" % "junit" % junitVersion % Test,
"com.github.sbt" % "junit-interface" % junitIfVersion % Test,
"org.hamcrest" % "hamcrest-all" % hamcrestVersion % Test,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ó, hamcrest... I expect to find some advanced JUnit magic below!

@Akirathan Akirathan mentioned this pull request Sep 29, 2023
5 tasks
@Akirathan
Copy link
Member Author

Assertions on the CI will be enabled in #7929

@Akirathan Akirathan added the CI: Ready to merge This PR is eligible for automatic merge label Sep 29, 2023
@mergify mergify bot merged commit 9f15b90 into develop Sep 29, 2023
26 checks passed
@mergify mergify bot deleted the wip/akirathan/asserts-5973 branch September 29, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Enso-specific asserts
4 participants