Enable Enso asserts on CI #7929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
radeusgd
reviewed
Sep 29, 2023
Akirathan
added
the
CI: No changelog needed
Akirathan
force-pushed
the
wip/akirathan/Enable-Enso-asserts
branch
from
6de74e6
to
6bd9b4c
Compare
Akirathan
requested review from
jdunkerley,
GregoryTravis and
mwu-tow
as code owners
Akirathan
force-pushed
the
wip/akirathan/Enable-Enso-asserts
branch
from
6bd9b4c
to
824c368
Compare
mwu-tow
approved these changes
Oct 2, 2023
GregoryTravis
approved these changes
Oct 2, 2023
| ret = Runtime.assert js_check | ||
| ret . should_be Nothing | ||
|
|
||
| Test.specify "should be able to take lambdas as expressions" <| |
There was a problem hiding this comment.
Maybe also an assertion failure test?
There was a problem hiding this comment.
There was a problem hiding this comment.
It's very basic, but there are many other tests in engine.
Akirathan
added
the
CI: Keep up to date
Akirathan
added
CI: Clean build required
|
Pavel Marek reports a new STANDUP for today (2023-10-04): Progress: - Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #7883
Pull Request Description
Enable Enso asserts (
Runtime.assert) on the CI by default. Even if JVM assertions are disabled.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.