-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting and Groups update #8357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Personally I'd change a few Metadata
groups in XML into Selections
, as they seem more natural to me, but maybe there is some other reason for how this is split?
@@ -210,7 +210,8 @@ type JS_Object | |||
to_default_visualization_data self = | |||
render self | |||
|
|||
## Creates an Enso object from the JS_Object. | |||
## GROUP Conversions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we not prefix this as Standard.Base.Conversions
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a scoping thing? It's implied since this is in Standard.Base
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's implied as in Standard.Base.
authority : Text | Nothing | ||
authority self = self.uri.authority | ||
|
||
## Get the port part of this URI. | ||
## GROUP Metadata | ||
Get the port part of this URI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like what @radeusgd said about XML elements, I wonder if this is something like Selections
. Nearly every part of the URI is classified as Metadata
here.
Pull Request Description
Blank_Selector
.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.