Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting and Groups update #8357

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Linting and Groups update #8357

merged 4 commits into from
Nov 21, 2023

Conversation

jdunkerley
Copy link
Member

Pull Request Description

  • Fix issues from the linter.
  • Rename the constructors for Blank_Selector.
  • Update various GROUP tags.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 21, 2023
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Personally I'd change a few Metadata groups in XML into Selections, as they seem more natural to me, but maybe there is some other reason for how this is split?

@@ -210,7 +210,8 @@ type JS_Object
to_default_visualization_data self =
render self

## Creates an Enso object from the JS_Object.
## GROUP Conversions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we not prefix this as Standard.Base.Conversions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a scoping thing? It's implied since this is in Standard.Base?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's implied as in Standard.Base.

authority : Text | Nothing
authority self = self.uri.authority

## Get the port part of this URI.
## GROUP Metadata
Get the port part of this URI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like what @radeusgd said about XML elements, I wonder if this is something like Selections. Nearly every part of the URI is classified as Metadata here.

@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Nov 21, 2023
@mergify mergify bot merged commit 347b5a7 into develop Nov 21, 2023
30 of 33 checks passed
@mergify mergify bot deleted the wip/jd/groups-labels-linting branch November 21, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants