Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't NPE on op ._ when translating tree to IR #8381

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Don't NPE on op ._ when translating tree to IR #8381

merged 1 commit into from
Nov 23, 2023

Conversation

hubertp
Copy link
Contributor

@hubertp hubertp commented Nov 23, 2023

Pull Request Description

Encountered a random NPE when playing with bookclubs. Test case demonstrating the problem is attached.

Threw in a bunch of minor tweaks to logs to make life of the person debugging code more pleasant.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@hubertp
Don't NPE on op ._ when translating tree to IR
80fa676 
Plus some minor tweaks to logs to make life of the person debugging code
more pleasant.
@hubertp hubertp added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 23, 2023
@hubertp hubertp added the CI: Ready to merge This PR is eligible for automatic merge label Nov 23, 2023
@mergify mergify bot merged commit 36996c8 into develop Nov 23, 2023
30 of 34 checks passed
@mergify mergify bot deleted the wip/hubert/fix-npe-underscore branch November 23, 2023 19:56
@enso-bot enso-bot bot mentioned this pull request Nov 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akirathan Akirathan Akirathan approved these changes

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hubertp @Akirathan @JaroslavTulach