Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedefinedMethodException when evaluating visualization argument #8296

Closed
hubertp opened this issue Nov 14, 2023 · 5 comments · Fixed by #8395
Closed

RedefinedMethodException when evaluating visualization argument #8296

hubertp opened this issue Nov 14, 2023 · 5 comments · Fixed by #8395
Assignees

Comments

@hubertp
Copy link
Contributor

hubertp commented Nov 14, 2023

[enso] Evaluation of visualization argument [['self', 'argument']] failed in module [local.Enso_Getting_Started_1.Main] with [RedefinedMethodException]: Methods cannot be overloaded, but you have tried to overload Main.main

No easy steps to reproduce and full stracktrace is missing. But likely a culprit for "stuck" visualizations on IDE.

@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Nov 14, 2023
@hubertp hubertp moved this from 📤 Backlog to 🔧 Implementation in Issues Board Nov 24, 2023
@hubertp
Copy link
Contributor Author

hubertp commented Nov 24, 2023

Finally figured that one out.

This is an unfortunate regression introduced in #7042 which lowered the scope of the writeCompilationLock. The problem is that evaluating the expression (now outside of the lock) in UpsertVisualizationJob may trigger a compilation. If during that time there is any other job that does the compilation as well, we get the exception.

@enso-bot
Copy link

enso-bot bot commented Nov 24, 2023

Hubert Plociniczak reports a new STANDUP for yesterday (2023-11-23):

Progress: Went back to #8296, trying to figure out the circumstances for the exception, while making my way through a bookclub. Didn't get far - fixed NPE #8381. Also, I assumed that java formatting would be fixed after jdk21 upgrade but #5461 is still broken; identified the problem in outdated version of google formatter of our sbt-java-formatter. #5461 is unlikely to be fixed by authors so we might have to fork and publish the artifact ourselves. It should be finished by 2023-11-24.

Next Day: Next day I will be working on the #8296 task. Get through a bookclub without problems and figure out #8296.

@enso-bot
Copy link

enso-bot bot commented Nov 27, 2023

Hubert Plociniczak reports a new STANDUP for the provided date (2023-11-24):

Progress: Briefly investigated #8376; turned out that some protocol condition was violated in the new GUI implementation. Got another deadlock while testing again bookclub (reported as #8383); no idea on the source of the error or a fix. Finally figured out under what conditions #8296 would randomly pop up - there is a problem with locks. Provided final feedback on old bookclub. It should be finished by 2023-11-24.

Next Day: Next day I will be working on the #8296 task. Create a PR that fixes the problem.

@mergify mergify bot closed this as completed in #8395 Nov 27, 2023
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Nov 27, 2023
mergify bot pushed a commit that referenced this issue Nov 27, 2023
Evaluating visualization expression may trigger a full compilation. A change in #7042 went a bit too far and led to a situation when there could be compilations running at the same time leading to a rather obscure `RedefinedMethodException` when the compilation on one thread already finished. This will make the logic correct again at the price of potentially slowing the processing of visualization.

Closes #8296.

# Important Notes
Should make visualizations a bit more stable as well.
@enso-bot
Copy link

enso-bot bot commented Nov 28, 2023

Hubert Plociniczak reports a new 🔴 DELAY for yesterday (2023-11-27):

Summary: There is 3 days delay in implementation of the RedefinedMethodException when evaluating visualization argument (#8296) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: Delay caused by reporting and investigating other stability issues.

@enso-bot
Copy link

enso-bot bot commented Nov 28, 2023

Hubert Plociniczak reports a new STANDUP for yesterday (2023-11-27):

Progress: Created a PR with a fix. Started looking into problems with MacOS on CI. Testing and reproducing other bugs like #8336 or #8383. Moving on from stability issues. It should be finished by 2023-11-27.

Next Day: Next day I will be working on the #8408 task. Investigating macos issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant