-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntactic synchronization #8880
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still have to get e2e tests working with the new model, but aside from the mock code this is ready for review. |
farmaazon
approved these changes
Jan 30, 2024
Integrated into #8893 (all review not addressed here has now been addressed there). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: Clean build required
CI runners will be cleaned before and after this PR is built.
CI: No changelog needed
Do not require a changelog entry for this PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Synchronize Y.Js clients by AST.
Implements #8237.
Important Notes
Reviewers: The first commit is mostly organizing things, the smaller commit is more interesting.
Parent-pointer consistency checks are not implemented yet. That will be important for multi-client, but it should be impossible to create inconsistent parents with only one user editing.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.