Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntactic synchronization #8880

Closed
wants to merge 11 commits into from
Closed

Syntactic synchronization #8880

wants to merge 11 commits into from

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Jan 27, 2024

Pull Request Description

Synchronize Y.Js clients by AST.

Implements #8237.

Important Notes

Reviewers: The first commit is mostly organizing things, the smaller commit is more interesting.

Parent-pointer consistency checks are not implemented yet. That will be important for multi-client, but it should be impossible to create inconsistent parents with only one user editing.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@kazcw kazcw added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 27, 2024
@kazcw kazcw self-assigned this Jan 27, 2024
@kazcw
Copy link
Contributor Author

kazcw commented Jan 27, 2024

I still have to get e2e tests working with the new model, but aside from the mock code this is ready for review.

@kazcw kazcw marked this pull request as ready for review January 27, 2024 06:53
@kazcw kazcw mentioned this pull request Jan 30, 2024
5 tasks
app/gui2/shared/ast/tree.ts Show resolved Hide resolved
app/gui2/src/util/ast/aliasAnalysis.ts Show resolved Hide resolved
app/gui2/src/util/docParser.ts Show resolved Hide resolved
app/gui2/shared/ast/tree.ts Show resolved Hide resolved
app/gui2/src/util/ast/abstract.ts Show resolved Hide resolved
app/gui2/src/components/GraphEditor/GraphEdges.vue Outdated Show resolved Hide resolved
app/gui2/src/stores/graph/index.ts Outdated Show resolved Hide resolved
app/gui2/src/stores/graph/index.ts Outdated Show resolved Hide resolved
app/gui2/src/stores/graph/index.ts Show resolved Hide resolved
@kazcw kazcw linked an issue Jan 30, 2024 that may be closed by this pull request
@kazcw kazcw added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Jan 30, 2024
@kazcw
Copy link
Contributor Author

kazcw commented Jan 31, 2024

Integrated into #8893 (all review not addressed here has now been addressed there).

@kazcw kazcw closed this Jan 31, 2024
@kazcw kazcw deleted the wip/kw/ast-sync branch January 31, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AST-based synchronization
2 participants