Minor cleanups to docker image #8925
Conversation
hubertp
requested review from
4e6,
JaroslavTulach,
radeusgd,
Akirathan,
jdunkerley,
farmaazon,
AdRiley,
PabloBuchu and
wdanilo
as code owners
| from a desired _edition_. The root directory of the docker build context can be | ||
| provided in the `docker build` command: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
certain number of directories to be present
What's the command to invoke before invoking docker build to get the "certain number of directories"?
There was a problem hiding this comment.
It's this argument built-distribution/enso-engine-$VERSION-linux-amd64/enso-$VERSION
| docker build -t <my-custom-name> -f tools/ci/docker/DockerFile --build-context docker-tools=tools/ci/docker built-distribution/enso-engine-$VERSION-linux-amd64/enso-$VERSION | ||
| ``` | ||
|
|
||
| where for a locally built distribution on Linux it would be `VERSION=0.0.0-dev`. |
There was a problem hiding this comment.
I wouldn't mind having sbt buildDockerImage that would invoke buildXyz and then passed in the right VERSION variable...
There was a problem hiding this comment.
Another advantage of sbt buildDockerImage would be that it could depend on buildEngineDistribution, from which it copies the directories.
| ARG RPC_PORT=30001 | ||
| ARG DATA_PORT=30002 | ||
| ARG PRINT_VERSION=0 | ||
| ARG JAVA_OPTS="-XX:MaxRAMPercentage=90.0 -XX:InitialRAMPercentage=90.0" |
There was a problem hiding this comment.
How did you find these are the right options? Do you have any reference?
There was a problem hiding this comment.
Past experience but not tested in battlefield with Enso. Gives enough room when JVM decides to go over the limit (which it occasionally can do).
hubertp
added
the
CI: No changelog needed
Pull Request Description
Added some sensible defaults which all can be overriden from the outside.
Most importantly, we want to use
MaxRAMPercentagejava option rather thanmxbecause the former plays better in the container setting.Important Notes
I wasn't able to test it with cloud's project manager, just as a standalone run so this will need more testing. Also not sure how the image is currently invoked.