Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .. to identify autoscoped constructors #9285

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Use .. to identify autoscoped constructors #9285

merged 3 commits into from
Mar 6, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Mar 5, 2024 •
edited
Loading

Pull Request Description

Fixes #9275.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach self-assigned this Mar 5, 2024
@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 5, 2024
@JaroslavTulach JaroslavTulach mentioned this pull request Mar 5, 2024
Merged
6 tasks
hubertp
hubertp reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to start language wars but... it's easy to write ... or .. by accident. Maybe something like ?Just instead of ..Just would work better?

@JaroslavTulach
Copy link
Member Author

Not to start language wars but...

The syntax discussion is the right place to express such opinions.

@JaroslavTulach
Copy link
Member Author

@jdunkerley, you wanted me to test:

from Standard.Base import all

main =
    a = 5
    a..7

which yields Method .. of type Integer could not be found. error.

@JaroslavTulach JaroslavTulach merged commit 6acec1b into develop Mar 6, 2024
25 of 28 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/DotDotAutoscoped_9275 branch March 6, 2024 09:28
somebody1234 pushed a commit that referenced this pull request Mar 6, 2024
@JaroslavTulach @somebody1234
Use .. to identify autoscoped constructors (#9285)
5dc3765
@enso-bot enso-bot bot mentioned this pull request Mar 7, 2024
Closed
@unfurl-links unfurl-links bot mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazcw kazcw kazcw left review comments

@farmaazon farmaazon farmaazon left review comments

@4e6 4e6 4e6 approved these changes

@radeusgd radeusgd radeusgd approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@wdanilo wdanilo Awaiting requested review from wdanilo

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefix autoscoped constructors with ..
9 participants
@JaroslavTulach @hubertp @4e6 @kazcw @radeusgd @wdanilo @farmaazon @jdunkerley @GregoryTravis