Autoscoped constructors

[JaroslavTulach]

Pull Request Description

Fixes #8645 by recognizing ~ prefix to constructor names.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated in bc5c6fd
• All code follows the
  Scala,
  Java,
  style guides.
• All code has been tested:
  • Unit tests have been written
  • Enso unit tests with examples
  • Test for error conditions
  • Write new benchmarks

[radeusgd]

Looks great, thanks for addressing my concerns and the thorough tests

[Akirathan]

LGTM. Seems that you are also correctly passing around State. Once you get to writing Enso tests, please, don't forget to test something like:

type My_Type
    False

    materialize t:My_Type =
        State.get Number . should_equal 42
        t.to_text

main =
    State.run Number 42 <|
        My_Type.materialize ~False

[JaroslavTulach]

8266b52 introduces new benchGenerateListAutoscoping. Use as:

sbt:runtime-benchmarks> benchOnly benchGenerateList
[info] AtomBenchmarks.benchGenerateList             avgt    5     4.026 ±   0.252  ms/op
[info] AtomBenchmarks.benchGenerateListAutoscoping  avgt    5  2581.386 ± 191.845  ms/op
[info] AtomBenchmarks.benchGenerateListQualified    avgt    5     4.294 ±   0.542  ms/op

right now the benchGenerateListAutoscoping is 500x times slower then other benchmarks not using autoscoping of constructors, but we'll make it faster.

[JaroslavTulach]

However, I think we should strive to give good error messages on failure. Could you share what is the error message if I try to use a ~Foo autoscoped constructor and the constructor is not found?

After 6987672 the message is Error: Type error: expected expression to be Back, but got ~Value

[JaroslavTulach]

LGTM. Seems that you are also correctly passing around State. Once you get to writing Enso tests, please, don't forget to test something like:

type My_Type
    False

    materialize t:My_Type =
        State.get Number . should_equal 42
        t.to_text

main =
    State.run Number 42 <|
        My_Type.materialize ~False

Thanks for bringing the topic of State up, @Akirathan. I believe it actually wasn't correct and your test wasn't testing State during materialization of the UnresolvedConstructor. Since a026086 the behavior shall be correct (if I understand what proper State behavior is supposed to be properly).

[radeusgd]

However, I think we should strive to give good error messages on failure. Could you share what is the error message if I try to use a ~Foo autoscoped constructor and the constructor is not found?

After 6987672 the message is Error: Type error: expected expression to be Back, but got ~Value

Personally I think it would be best to have a more specific message, e.g. Could not resolve ~Value as a constructor on type Back.. But I guess the current one is okay-ish and we can revise later when we see how this behaves in practice.

[JaroslavTulach]

Documenting autoscoped constructors is hard when most of the surrounding documentation is outdated...

[JaroslavTulach]

have a more specific message, e.g. Could not resolve ~Value as a constructor on type Back..

Done in 6e32a3a

[JaroslavTulach]

Done in 6e32a3a

Now we have a missing TruffleBoundary problem... let's concatenate the message via ropes in 60bfc76

[JaroslavTulach]

We are in. Dmitry reported

• Use autoscoping when constructing tag values of suggestion arguments #9259

as a followup issue to make static dropdowns work in the IDE.

[JaroslavTulach]

Syntax is being changed by

• Use .. to identify autoscoped constructors #9285