Ast.Vector #9328
Merged
Ast.Vector #9328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazcw
added
CI: No changelog needed
kazcw
requested review from
Frizi,
farmaazon,
MichaelMauderer and
vitvakatu
as code owners
vitvakatu
approved these changes
Mar 8, 2024
Comment on lines
53
to
54
| : props.input.expectedType?.startsWith('Standard.Base.Data.Vector.Vector') ? Score.Good | ||
| : props.input.value instanceof Ast.Vector ? Score.Perfect |
There was a problem hiding this comment.
nit: I suggest switching these lines. If we have vector Ast and the expected type is Vector, it should be a perfect match, not Good.
| @@ -231,12 +232,27 @@ const yLabelLeft = computed( | |||
| ) | |||
| const yLabelTop = computed(() => -margin.value.left + 15) | |||
|
|
|||
| function vectorOfNumericLiterals(values: number[]): Ast.Owned | undefined { | |||
There was a problem hiding this comment.
What about moving this to utils? Seems like a useful function.
| const escapeString = (str: string): string => { | ||
| const escaped = str.replaceAll(/([\\'])/g, '\\$1') | ||
| return `'${escaped}'` | ||
| function vectorOfTextLiterals(values: string[]): Ast.Owned { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add
VectorAST type, corresponding to theRawAst.Tree.Arraytype (nameArraynot used for obvious reasons).This is the first step of #5138.
Important Notes
Vector.new, improving type-safety.Astchanges are covered by the round-trip tests; the use-site changes have been tested manually.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.