Better error message in Data.read when an argument to format is missing
#9337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
added
the
CI: No changelog needed
radeusgd
requested review from
jdunkerley,
GregoryTravis and
AdRiley
as code owners
|
Before: After: |
jdunkerley
approved these changes
Mar 8, 2024
Comment on lines
2961
to
2964
| Text.from (that : Table) (format:Delimited_Format = Delimited_Format.Delimited '\t') = | ||
| File_Format.handle_format_missing_arguments format <| case format of | ||
| _ : Delimited_Format -> Delimited_Writer.write_text that format | ||
| _ -> Unimplemented.throw "Text.from is currently only implemented for Delimited_Format." |
There was a problem hiding this comment.
not needed here as the format argument is type checked.
We possibly should remove some of the code from here or the type checking.
There was a problem hiding this comment.
Oh indeed I have missed that.
Hmm, I guess we can keep the typecheck and simplify.
GregoryTravis
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.