Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move selections to a new layer #9344

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Move selections to a new layer #9344

merged 3 commits into from
Mar 11, 2024

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Mar 8, 2024

Pull Request Description

Move selections to a new Vue component so that they don't interfere with clicking on edges.

Screen.Recording.2024-03-08.at.14.47.30.mov

Important Notes

  • The new GraphNodeSelection components are drawn in a GraphNodeSelections container. They are created by the GraphNodes and teleported so that the node can set properties directly.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@kazcw kazcw added CI: No changelog needed Do not require a changelog entry for this PR. -gui labels Mar 8, 2024
@kazcw kazcw self-assigned this Mar 8, 2024
@kazcw kazcw linked an issue Mar 8, 2024 that may be closed by this pull request
2 tasks
@kazcw kazcw added the CI: Ready to merge This PR is eligible for automatic merge label Mar 11, 2024
@mergify mergify bot merged commit 1f6db1e into develop Mar 11, 2024
33 of 35 checks passed
@mergify mergify bot deleted the wip/kw/selections-layer branch March 11, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't interact with edges in the default node layout
2 participants