Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker #9570

Merged
merged 12 commits into from
Apr 2, 2024
Merged

Color picker #9570

merged 12 commits into from
Apr 2, 2024

Conversation

vitvakatu
Copy link
Contributor

Pull Request Description

Closes #8680

The color picker is triggered by new Circular menu item or by keyboard shortcut (set to Mod+Shift+C for Color).
The color picker affects selected nodes, so it works nicely both in cases when we use Circular menu on a single node a shortcut with multiple selected nodes.

Color is only changed when the user selects a new one inside the color picker, but there is no specific way to reset default color (you would have to recreate the node).

changing.node.colors.mp4

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@vitvakatu vitvakatu added x-new-feature Type: new feature request -gui labels Mar 28, 2024
@vitvakatu vitvakatu self-assigned this Mar 28, 2024
@vitvakatu vitvakatu added CI: Ready to merge This PR is eligible for automatic merge CI: No changelog needed Do not require a changelog entry for this PR. labels Apr 1, 2024
@mergify mergify bot merged commit bef6f3a into develop Apr 2, 2024
41 checks passed
@mergify mergify bot deleted the wip/vitvakatu/colors branch April 2, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge x-new-feature Type: new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability for user to choose color of individual components
2 participants