Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for user to choose color of individual components #8680

Closed
AdRiley opened this issue Jan 4, 2024 · 10 comments · Fixed by #9570
Closed

Add ability for user to choose color of individual components #8680

AdRiley opened this issue Jan 4, 2024 · 10 comments · Fixed by #9570
Assignees
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Milestone

Comments

@AdRiley
Copy link
Member

AdRiley commented Jan 4, 2024

  • Serialise the colour into the metadata so it can be restored on opening.
  • Default colour comes from the group as currently.
  • User can pick a colour in the full wheel component menu.
  • Use an off the shelf color picker from Tailwind (maybe https://tw-elements.com/docs/standard/extended/color-picker/ ?)
  • Menu icon is a circle shaded with the current color paintbrush paint_palette in far right (East?) position on full wheel

Image

@AdRiley AdRiley added -gui x-new-feature Type: new feature request labels Jan 5, 2024
@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints labels Feb 6, 2024
@AdRiley AdRiley added this to the Beta Release milestone Feb 19, 2024
@farmaazon
Copy link
Contributor

Refinement notes:

  • The tool above may not be a vue component. We can just use it as react component under the hood, or look for something else.
  • Clicking icon should color only the single node (the one where menu is opened). Also, we want to add shortcut to color all selected nodes.

@enso-bot
Copy link

enso-bot bot commented Mar 15, 2024

Ilya Bogdanov reports a new STANDUP for today (2024-03-15):

Progress: Working on color picker for nodes. Selected a vue3-compatible library, integrated it with the circular menu, added metadata field for color. Working on managing focus for the color picker window, and logic of updating nodes colors. It should be finished by 2024-03-19.

@enso-bot
Copy link

enso-bot bot commented Mar 21, 2024

Ilya Bogdanov reports a new 🔴 DELAY for yesterday (2024-03-20):

Summary: There is 3 days delay in implementation of the Add ability for user to choose color of individual components (#8680) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: Sick leave

@enso-bot
Copy link

enso-bot bot commented Mar 21, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-03-20):

Progress: Having reduced hours because of being sick. Changed used color picker component to a more flexible one, also refactored the code to allow setting colors on multiple nodes. It should be finished by 2024-03-22.

@enso-bot
Copy link

enso-bot bot commented Mar 25, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-03-22):

Progress: Joint standup for 2024-03-22 and 2024-03-21. Reduced working hours because of illness. Finishing the implementation, fixing issue with positioning of the color picker. Preparing a PR, noticed missed corner cases when recording the video for the PR. It should be finished by 2024-03-22.

@enso-bot
Copy link

enso-bot bot commented Mar 26, 2024

Ilya Bogdanov reports a new 🔴 DELAY for yesterday (2024-03-25):

Summary: There is 3 days delay in implementation of the Add ability for user to choose color of individual components (#8680) task.
It will cause 0 days delay for the delivery of this weekly plan.

2 days are weekends

Delay Cause: slow progress with fixing unnoticed bug

@enso-bot
Copy link

enso-bot bot commented Mar 26, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-03-25):

Progress: Fixing missing corner cases by refactoring color management of the nodes in graph editor, merging with develop, preparing a PR. It should be finished by 2024-03-25.

@vitvakatu vitvakatu mentioned this issue Mar 28, 2024
5 tasks
@enso-bot
Copy link

enso-bot bot commented Apr 1, 2024

Ilya Bogdanov reports a new 🔴 DELAY for today (2024-04-01):

Summary: There is 3 days delay in implementation of the Add ability for user to choose color of individual components (#8680) task.
It will cause 0 days delay for the delivery of this weekly plan.

1 day off

Delay Cause: Slow progress with preparing a PR and fixing annoying corner-cases.

@enso-bot
Copy link

enso-bot bot commented Apr 1, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-03-27):

Progress: Standup for 2024-03-28. Fixing last-minute issues, polishing the code. Making sure color picker works properly for multiple nodes being selected. It should be finished by 2024-03-28.

@enso-bot
Copy link

enso-bot bot commented Apr 1, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-03-28):

Progress: Discovered another way of fixing color picker behavior without modifying the graph editor codebase. Implemented this refactor and opened a PR. Going through bookclubs. It should be finished by 2024-03-28.

@mergify mergify bot closed this as completed in #9570 Apr 2, 2024
mergify bot pushed a commit that referenced this issue Apr 2, 2024
Closes #8680

The color picker is triggered by new Circular menu item or by keyboard shortcut (set to `Mod+Shift+C` for **C**olor).
The color picker affects *selected* nodes, so it works nicely both in cases when we use Circular menu on a single node a shortcut with multiple selected nodes.

Color is only changed when the user selects a new one inside the color picker, but there is no specific way to reset default color (you would have to recreate the node).

https://github.com/enso-org/enso/assets/6566674/a4497bea-f432-486d-85f8-f2772ba5694f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants