-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add range info to Out_Of_Range
error
#9586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message is ignored in to_display_text
- but that is the user-facing text where it definitely should be included too.
Also please add a test of to_display_text
- as I mentioned in some review recently - we used to have regressions in these and if they do not have unit tests, we learn about these only when they occur in the IDE - which may be found rarely if the warning is not one seen every day.
Yes, I forgot to change that one -- done. |
looks good - might be worth having the limit in the message for clarity. |
Added. |
Followup from #9462.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.