Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range info to Out_Of_Range error #9586

Merged
merged 9 commits into from
Apr 4, 2024

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Apr 1, 2024

Followup from #9462.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@GregoryTravis GregoryTravis marked this pull request as ready for review April 1, 2024 18:00
@GregoryTravis GregoryTravis added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 1, 2024
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message is ignored in to_display_text - but that is the user-facing text where it definitely should be included too.

Also please add a test of to_display_text - as I mentioned in some review recently - we used to have regressions in these and if they do not have unit tests, we learn about these only when they occur in the IDE - which may be found rarely if the warning is not one seen every day.

@GregoryTravis
Copy link
Contributor Author

The message is ignored in to_display_text - but that is the user-facing text where it definitely should be included too.

Also please add a test of to_display_text - as I mentioned in some review recently - we used to have regressions in these and if they do not have unit tests, we learn about these only when they occur in the IDE - which may be found rarely if the warning is not one seen every day.

Yes, I forgot to change that one -- done.

@jdunkerley
Copy link
Member

looks good - might be worth having the limit in the message for clarity.

@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Apr 2, 2024
@GregoryTravis
Copy link
Contributor Author

looks good - might be worth having the limit in the message for clarity.

Added.

@jdunkerley jdunkerley added the CI: Keep up to date Automatically update this PR to the latest develop. label Apr 4, 2024
@jdunkerley jdunkerley removed the CI: Keep up to date Automatically update this PR to the latest develop. label Apr 4, 2024
@mergify mergify bot merged commit 67b5745 into develop Apr 4, 2024
37 checks passed
@mergify mergify bot deleted the wip/gmt/8982-conversion-int-float-followup branch April 4, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants