Hide errors from input nodes #9633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazcw
added
the
CI: No changelog needed
…ed-errors # Conflicts: # app/gui2/src/components/GraphEditor/GraphNode.vue
farmaazon
approved these changes
Apr 5, 2024
Comment on lines
12
to
28
| type MessageType = 'error' | 'warning' | 'panic' | ||
| /** The type of a message. */ | ||
| export class GraphNodeMessageType { | ||
| private constructor(private readonly type: MessageType) {} | ||
|
|
||
| static Error: GraphNodeMessageType = new GraphNodeMessageType('error') | ||
| static Warning: GraphNodeMessageType = new GraphNodeMessageType('warning') | ||
| static Panic: GraphNodeMessageType = new GraphNodeMessageType('panic') | ||
|
|
||
| get iconName() { | ||
| return iconForMessageType[this.type] | ||
| } | ||
|
|
||
| const iconForType: Record<GraphNodeMessageType, Icon | undefined> = { | ||
| get cssColor() { | ||
| return colorForMessageType[this.type] | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we actually need a separate class for it? I would stay with just MessageType and exported constants below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When a node has an error/warning/panic that exactly matches one of its input nodes, hide the message until the node is interacted with, showing an icon.
hiding-errors.mov
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.