Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore state after reconnecting #9755

Merged
merged 7 commits into from
Apr 25, 2024
Merged

Restore state after reconnecting #9755

merged 7 commits into from
Apr 25, 2024

Conversation

farmaazon
Copy link
Contributor

@farmaazon farmaazon commented Apr 19, 2024

Pull Request Description

Fixes: #8522

Execution context is refactored slightly: now we have a single sync function to synchronize both visualization and execution stack.

Tested hibernation on Linux: I was able to continue my work 🎉

Important Notes

The Refinement Notes state, that the execution mode should be set before updating the stack, but actually it makes an error on startup (changing context automatically re-executes programs, what fails if there's no frame on the stack).

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@farmaazon farmaazon added CI: No changelog needed Do not require a changelog entry for this PR. -gui labels Apr 19, 2024
@farmaazon farmaazon self-assigned this Apr 19, 2024
@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Apr 24, 2024
@mergify mergify bot merged commit 5807c5c into develop Apr 25, 2024
36 checks passed
@mergify mergify bot deleted the wip/farmaazon/restoring branch April 25, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore client state after reconnecting with engine
2 participants