Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore client state after reconnecting with engine #8522

Closed
Tracked by #5202
farmaazon opened this issue Dec 12, 2023 · 3 comments · Fixed by #9755
Closed
Tracked by #5202

Restore client state after reconnecting with engine #8522

farmaazon opened this issue Dec 12, 2023 · 3 comments · Fixed by #9755
Assignees
@farmaazon
Labels
-gui d-hard Difficulty: significant prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Milestone
Beta Release

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Dec 12, 2023 •
edited
Loading

After reconnecting, LS is a fresh instance, so the clients have to:

  • Initialize protocol again
  • Recreate execution context
  • Re-attach visualizations
  • Reset execution mode
@farmaazon farmaazon mentioned this issue Dec 12, 2023
Closed
@farmaazon farmaazon added d-hard Difficulty: significant prior knowledge required --breaking Important: a change that will break a public API or user-facing behaviour p-medium Should be completed in the next few sprints x-new-feature Type: new feature request -gui and removed --breaking Important: a change that will break a public API or user-facing behaviour labels Dec 12, 2023
@farmaazon farmaazon changed the title Restore client state (execution context, visualizations, execution mode) Restore client state after reconnecting with engine Dec 12, 2023
@farmaazon farmaazon mentioned this issue Dec 12, 2023
Closed
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Dec 12, 2023
@farmaazon
Copy link
Contributor Author

Refinement notes:

  • Execution mode has to be reset before triggering execution (before pushing any frame).

@farmaazon farmaazon assigned vitvakatu and unassigned vitvakatu Jan 29, 2024
@farmaazon farmaazon assigned Frizi and unassigned vitvakatu Feb 5, 2024
@AdRiley AdRiley added this to the Beta Release milestone Feb 8, 2024
@farmaazon farmaazon assigned farmaazon and unassigned Frizi Mar 28, 2024
@farmaazon farmaazon moved this from 📤 Backlog to 🔧 Implementation in Issues Board Apr 15, 2024
@enso-bot
Copy link

enso-bot bot commented Apr 16, 2024

Adam Obuchowicz reports a new STANDUP for yesterday (2024-04-15):

Progress: Refactored Execution Context to sync all the state (not only visualizations) It should be finished by 2024-04-26.

Next Day: Next day I will be working on the same task. Update "actual" state after reconnection and a bit more refactoring. Test if hibernation works.

@farmaazon farmaazon mentioned this issue Apr 19, 2024
Merged
5 tasks
@farmaazon farmaazon moved this from 🔧 Implementation to 👁️ Code review in Issues Board Apr 19, 2024
@enso-bot
Copy link

enso-bot bot commented Apr 19, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-04-19):

Progress: Tested. No further issues found. Created a PR It should be finished by 2024-04-26.

Next Day: Next day I will be working on the #9519 task. Apply any review comment and maybe more testing. And start next task

@mergify mergify bot closed this as completed in #9755 Apr 25, 2024
mergify bot pushed a commit that referenced this issue Apr 25, 2024
@farmaazon
Restore state after reconnecting (#9755)
5807c5c 
Fixes: #8522

Execution context is refactored slightly: now we have a single `sync` function to synchronize both visualization and execution stack.

Tested hibernation on Linux: I was able to continue my work  🎉

# Important Notes
The Refinement Notes state, that the execution mode should be set before updating the stack, but actually it makes an error on startup (changing context automatically re-executes programs, what fails if there's no frame on the stack).
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Apr 25, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@farmaazon farmaazon

Labels
-gui d-hard Difficulty: significant prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Restore state after reconnecting enso-org/enso
5 participants
@Frizi @MichaelMauderer @AdRiley @farmaazon @vitvakatu