Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set of improvements: selection "committed" state and "add new compnent" button hitbox fix. #9775

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

farmaazon
Copy link
Contributor

Pull Request Description

  1. Did selection refactoring as follow-up of Visual way to group components #9519. Now the circular menu visibility or node extension is altered only when selection is ended (before, node shrank once the selection started a bit less blinking).
Screencast.from.2024-04-24.10-56-05.webm
  1. Fixes Add component button click zone needs to be bigger #9699 I don't know why the add-node button shape was done in :before element, if it happily works by shaping the main div itself.
Screencast.from.2024-04-24.10-51-57.webm

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • [ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@farmaazon farmaazon added CI: No changelog needed Do not require a changelog entry for this PR. -gui labels Apr 24, 2024
@farmaazon farmaazon self-assigned this Apr 24, 2024
@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Apr 25, 2024
@mergify mergify bot merged commit 210f048 into develop Apr 29, 2024
34 checks passed
@mergify mergify bot deleted the wip/farmaazon/fixes branch April 29, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add component button click zone needs to be bigger
2 participants