-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call showAll on opening projects #9974
Conversation
function waitInitializationAndPanToAll() { | ||
stopInitialization.value?.() | ||
stopInitialization.value = watchEffect(() => { | ||
const nodesCount = [...graphStore.db.nodeIdToNode.keys()].length |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nodeIdToNode.size
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, don’t ask how it appeared
waitInitializationAndPanToAll, | ||
) | ||
|
||
const stopInitialization = ref<() => void>() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be reactive?
const visibleNodeAreas = graphStore.visibleNodeAreas | ||
if (nodesCount > 0 && visibleNodeAreas.length == nodesCount) { | ||
zoomToSelected(true) | ||
stopInitialization.value?.() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting it to undefined
would allow it to be freed
4cfc694
to
72b4609
Compare
Sorry for ping guys, wrong rebase |
Pull Request Description
Fixes #9902
node.positions.initialized.mp4
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.